[clang] [clang][modules] Separate parsing of modulemaps (PR #119740)

Volodymyr Sapsai via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 10 12:07:33 PST 2025


================
@@ -0,0 +1,141 @@
+//===- ModuleMapFile.h - Parsing and representation -------------*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#ifndef LLVM_CLANG_LEX_MODULEMAPFILE_H
+#define LLVM_CLANG_LEX_MODULEMAPFILE_H
+
+#include "clang/Basic/LLVM.h"
+// TODO: Consider moving ModuleId to another header, parsing a modulemap file is
+//   intended to not depend on anything about the clang::Module class.
+#include "clang/Basic/Module.h"
+#include "clang/Basic/SourceLocation.h"
+#include "llvm/ADT/StringRef.h"
+
+#include <optional>
+#include <variant>
+
+namespace clang {
+
+class DiagnosticsEngine;
+class SourceManager;
+
+namespace modulemap {
+
+using Decl =
----------------
vsapsai wrote:

The name is very close to `clang::Decl` though don't know if it causes any problems in practice. I'm mostly concerned if an engineer starts looking into this code and they see `Decl` it can confuse them. Don't know if the name `AnyDecl` is better. Don't. have a strong opinion on this as I don't have any evidence.

https://github.com/llvm/llvm-project/pull/119740


More information about the cfe-commits mailing list