[clang] [clang] Refactor attr diagnostics to use %select (PR #122473)

[Maksim Ivanov via cfe-commits]

================
@@ -3708,9 +3709,9 @@ void Parser::ParseDeclarationSpecifiers(
             continue;
 
           if (PA.getKind() == ParsedAttr::AT_LifetimeBound)
-            Diag(PA.getLoc(), diag::err_attribute_wrong_decl_type_str)
----------------
emaxx-google wrote:

There are callsites left there: https://github.com/llvm/llvm-project/blob/dff7ef2353fec9f1006895c0e99bde704296eaa9/clang/utils/TableGen/ClangAttrEmitter.cpp#L4261 . These are less obvious to fix, and also the strings there are autogenerated themselves (based on other tablegens if I understand correctly).

https://github.com/llvm/llvm-project/pull/122473