[clang] [Darwin][Driver][clang] arm64-apple-none-macho is missing the Apple macros from arm-apple-none-macho (PR #122427)

Jon Roelofs via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 10 09:01:53 PST 2025


================
@@ -243,6 +247,8 @@ std::unique_ptr<TargetInfo> AllocateTarget(const llvm::Triple &Triple,
   case llvm::Triple::thumbeb:
----------------
jroelofs wrote:

github won't let me add a comment in the right spot, but I think we need:

```
  case llvm::Triple::arm:
  case llvm::Triple::thumb:
    if (Triple.isOSBinFormatMachO())
      return std::make_unique<DarwinARMTargetInfo>(Triple, Opts);
    else if (Triple.isAppleMachO())
      return std::make_unique<AppleMachOARMTargetInfo>(Triple, Opts);
  ```

https://github.com/llvm/llvm-project/pull/122427


More information about the cfe-commits mailing list