[clang] [clang][AST] Assert that DependentNameType::Name is not null (PR #122418)
via cfe-commits
cfe-commits at lists.llvm.org
Thu Jan 9 20:58:09 PST 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-clang
Author: Nathan Ridge (HighCommander4)
<details>
<summary>Changes</summary>
Also clarify the comment above DependentNameType::getIdentifier()
---
Full diff: https://github.com/llvm/llvm-project/pull/122418.diff
1 Files Affected:
- (modified) clang/include/clang/AST/Type.h (+5-6)
``````````diff
diff --git a/clang/include/clang/AST/Type.h b/clang/include/clang/AST/Type.h
index 09c98f642852fc..2ec59c2cb9a8f6 100644
--- a/clang/include/clang/AST/Type.h
+++ b/clang/include/clang/AST/Type.h
@@ -7035,17 +7035,16 @@ class DependentNameType : public TypeWithKeyword, public llvm::FoldingSetNode {
: TypeWithKeyword(Keyword, DependentName, CanonType,
TypeDependence::DependentInstantiation |
toTypeDependence(NNS->getDependence())),
- NNS(NNS), Name(Name) {}
+ NNS(NNS), Name(Name) {
+ assert(Name);
+ }
public:
/// Retrieve the qualification on this type.
NestedNameSpecifier *getQualifier() const { return NNS; }
- /// Retrieve the type named by the typename specifier as an identifier.
- ///
- /// This routine will return a non-NULL identifier pointer when the
- /// form of the original typename was terminated by an identifier,
- /// e.g., "typename T::type".
+ /// Retrieve the identifier that terminates this type name.
+ /// For example, "type" in "typename T::type".
const IdentifierInfo *getIdentifier() const {
return Name;
}
``````````
</details>
https://github.com/llvm/llvm-project/pull/122418
More information about the cfe-commits
mailing list