[clang] [clang-tools-extra] [clang] Avoid re-evaluating field bitwidth (PR #117732)

Wed Jan 8 06:20:39 PST 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `lldb-aarch64-ubuntu` running on `linaro-lldb-aarch64-ubuntu` while building `clang-tools-extra,clang` at step 6 "test".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/59/builds/10743

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 6 (test) failure: build (failure)
...
PASS: lldb-api :: commands/command/script/import/TestImport.py (24 of 2064)
PASS: lldb-api :: commands/command/script_alias/TestCommandScriptAlias.py (25 of 2064)
PASS: lldb-api :: commands/command/source/TestCommandSource.py (26 of 2064)
PASS: lldb-api :: commands/command/backticks/TestBackticksInAlias.py (27 of 2064)
PASS: lldb-api :: commands/disassemble/basic/TestFrameDisassemble.py (28 of 2064)
PASS: lldb-api :: commands/disassemble/basic/TestDisassembleBreakpoint.py (29 of 2064)
PASS: lldb-api :: commands/expression/calculator_mode/TestCalculatorMode.py (30 of 2064)
PASS: lldb-api :: commands/expression/anonymous-struct/TestCallUserAnonTypedef.py (31 of 2064)
PASS: lldb-api :: commands/expression/argument_passing_restrictions/TestArgumentPassingRestrictions.py (32 of 2064)
UNRESOLVED: lldb-api :: commands/expression/bitfield_enums/TestBitfieldEnums.py (33 of 2064)
******************** TEST 'lldb-api :: commands/expression/bitfield_enums/TestBitfieldEnums.py' FAILED ********************
Script:
--
/usr/bin/python3.10 /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/llvm-project/lldb/test/API/dotest.py -u CXXFLAGS -u CFLAGS --env LLVM_LIBS_DIR=/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/./lib --env LLVM_INCLUDE_DIR=/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/include --env LLVM_TOOLS_DIR=/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/./bin --arch aarch64 --build-dir /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/lldb-test-build.noindex --lldb-module-cache-dir /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/lldb-test-build.noindex/module-cache-lldb/lldb-api --clang-module-cache-dir /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/lldb-test-build.noindex/module-cache-clang/lldb-api --executable /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/./bin/lldb --compiler /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/./bin/clang --dsymutil /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/./bin/dsymutil --make /usr/bin/gmake --llvm-tools-dir /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/./bin --lldb-obj-root /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/tools/lldb --lldb-libs-dir /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/./lib /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/llvm-project/lldb/test/API/commands/expression/bitfield_enums -p TestBitfieldEnums.py
--
Exit Code: -6

Command Output (stdout):
--
lldb version 20.0.0git (https://github.com/llvm/llvm-project.git revision 81fc3add1e627c23b7270fe2739cdacc09063e54)
  clang revision 81fc3add1e627c23b7270fe2739cdacc09063e54
  llvm revision 81fc3add1e627c23b7270fe2739cdacc09063e54

--
Command Output (stderr):
--
UNSUPPORTED: LLDB (/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/bin/clang-aarch64) :: test_bitfield_enums_dsym (TestBitfieldEnums.TestBitfieldEnum) (test case does not fall in any category of interest for this run) 
python3.10: ../llvm-project/clang/lib/AST/Decl.cpp:4604: unsigned int clang::FieldDecl::getBitWidthValue() const: Assertion `isa<ConstantExpr>(getBitWidth())' failed.
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace.
Stack dump:
0.	<eof> parser at end of file
1.	<lldb wrapper prefix>:43:1: Generating code for declaration '$__lldb_expr'
  #0 0x0000ffff7a51ddc0 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) Signals.cpp:0:0
  #1 0x0000ffff7a51be1c llvm::sys::RunSignalHandlers() Signals.cpp:0:0
  #2 0x0000ffff7a51e4d0 SignalHandler(int) Signals.cpp:0:0
  #3 0x0000ffff814337dc (linux-vdso.so.1+0x7dc)
  #4 0x0000ffff811bf200 __pthread_kill_implementation ./nptl/./nptl/pthread_kill.c:44:76
  #5 0x0000ffff8117a67c gsignal ./signal/../sysdeps/posix/raise.c:27:6
  #6 0x0000ffff81167130 abort ./stdlib/./stdlib/abort.c:81:7
  #7 0x0000ffff81173fd0 __assert_fail_base ./assert/./assert/assert.c:89:7
  #8 0x0000ffff81174040 __assert_perror_fail ./assert/./assert/assert-perr.c:31:1
  #9 0x0000ffff7e00b5b4 clang::FieldDecl::getBitWidthValue() const Decl.cpp:0:0
 #10 0x0000ffff7e446dc8 (anonymous namespace)::ItaniumRecordLayoutBuilder::LayoutField(clang::FieldDecl const*, bool) RecordLayoutBuilder.cpp:0:0
 #11 0x0000ffff7e4443e4 (anonymous namespace)::ItaniumRecordLayoutBuilder::LayoutFields(clang::RecordDecl const*) RecordLayoutBuilder.cpp:0:0
 #12 0x0000ffff7e43c99c clang::ASTContext::getASTRecordLayout(clang::RecordDecl const*) const RecordLayoutBuilder.cpp:0:0
 #13 0x0000ffff7c228f38 lldb_private::ClangASTImporter::importRecordLayoutFromOrigin(clang::RecordDecl const*, unsigned long&, unsigned long&, llvm::DenseMap<clang::FieldDecl const*, unsigned long, llvm::DenseMapInfo<clang::FieldDecl const*, void>, llvm::detail::DenseMapPair<clang::FieldDecl const*, unsigned long> >&, llvm::DenseMap<clang::CXXRecordDecl const*, clang::CharUnits, llvm::DenseMapInfo<clang::CXXRecordDecl const*, void>, llvm::detail::DenseMapPair<clang::CXXRecordDecl const*, clang::CharUnits> >&, llvm::DenseMap<clang::CXXRecordDecl const*, clang::CharUnits, llvm::DenseMapInfo<clang::CXXRecordDecl const*, void>, llvm::detail::DenseMapPair<clang::CXXRecordDecl const*, clang::CharUnits> >&) ClangASTImporter.cpp:0:0
 #14 0x0000ffff7e4441d4 (anonymous namespace)::ItaniumRecordLayoutBuilder::InitializeLayout(clang::Decl const*) RecordLayoutBuilder.cpp:0:0
 #15 0x0000ffff7e43aa00 clang::ASTContext::getASTRecordLayout(clang::RecordDecl const*) const RecordLayoutBuilder.cpp:0:0
 #16 0x0000ffff7c484ae0 clang::CodeGen::CodeGenModule::getClassPointerAlignment(clang::CXXRecordDecl const*) CGClass.cpp:0:0

```

</details>

https://github.com/llvm/llvm-project/pull/117732