[clang] [Coverage] Introduce `getBranchCounterPair()`. NFC. (PR #112702)

[Jessica Paquette via cfe-commits]

================
@@ -939,8 +939,17 @@ struct CounterCoverageMappingBuilder
     Counter Skipped;
   };
 
-  BranchCounterPair getBranchCounterPair(const Stmt *S, Counter ParentCnt) {
+  BranchCounterPair
+  getBranchCounterPair(const Stmt *S, Counter ParentCnt,
+                       std::optional<Counter> SkipCntForOld = std::nullopt) {
     Counter ExecCnt = getRegionCounter(S);
+
+    // The old behavior of SingleByte shouldn't emit Branches.
+    if (llvm::EnableSingleByteCoverage) {
+      assert(SkipCntForOld);
----------------
ornata wrote:

if someone else runs into a problem, it will make it easier for them to understand what is going on

https://github.com/llvm/llvm-project/pull/112702