[clang] Use range-based for to iterate over fields in record layout, NFC (PR #122029)

via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 7 16:32:12 PST 2025


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff 1855333e3a843174c0d7421d4c5e404649f6b75a 1824674744d6fba1dd74c74d54aae9b603d8b854 --extensions cpp,h -- clang/include/clang/AST/Decl.h clang/lib/AST/Decl.cpp clang/lib/AST/RecordLayoutBuilder.cpp clang/lib/CodeGen/CGRecordLayoutBuilder.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/clang/include/clang/AST/Decl.h b/clang/include/clang/AST/Decl.h
index 7f6c1867bb..881c27423b 100644
--- a/clang/include/clang/AST/Decl.h
+++ b/clang/include/clang/AST/Decl.h
@@ -3128,7 +3128,6 @@ private:
   void setCachedFieldIndex() const;
 
 public:
-
   /// Determines whether this field is mutable (C++ only).
   bool isMutable() const { return Mutable; }
 
diff --git a/clang/lib/AST/RecordLayoutBuilder.cpp b/clang/lib/AST/RecordLayoutBuilder.cpp
index b287a7d5f6..afe29433db 100644
--- a/clang/lib/AST/RecordLayoutBuilder.cpp
+++ b/clang/lib/AST/RecordLayoutBuilder.cpp
@@ -138,8 +138,8 @@ class EmptySubobjectMap {
     return Offset <= MaxEmptyClassOffset;
   }
 
-  CharUnits
-  getFieldOffset(const ASTRecordLayout &Layout, const FieldDecl *Field) const {
+  CharUnits getFieldOffset(const ASTRecordLayout &Layout,
+                           const FieldDecl *Field) const {
     uint64_t FieldOffset = Layout.getFieldOffset(Field->getFieldIndex());
     assert(FieldOffset % CharWidth == 0 &&
            "Field offset not at char boundary!");
@@ -3661,7 +3661,8 @@ static void DumpRecordLayout(raw_ostream &OS, const RecordDecl *RD,
 
   // Dump fields.
   for (const FieldDecl *Field : RD->fields()) {
-    uint64_t LocalFieldOffsetInBits = Layout.getFieldOffset(Field->getFieldIndex());
+    uint64_t LocalFieldOffsetInBits =
+        Layout.getFieldOffset(Field->getFieldIndex());
     CharUnits FieldOffset =
       Offset + C.toCharUnitsFromBits(LocalFieldOffsetInBits);
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/122029


More information about the cfe-commits mailing list