[clang] [clang] add llvm abi support (PR #121123)

Chris B via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 6 16:28:08 PST 2025


================
@@ -1531,7 +1531,7 @@ Compilation *Driver::BuildCompilation(ArrayRef<const char *> ArgList) {
 
   // Check if the environment version is valid except wasm case.
   llvm::Triple Triple = TC.getTriple();
-  if (!Triple.isWasm()) {
+  if (!Triple.isWasm() && Triple.getEnvironment() != llvm::Triple::LLVM) {
----------------
llvm-beanz wrote:

This seems wrong to me. Opting out of here makes me think there is something wrong with how the LLVM environment was implemented in the triple.

The Wasm case is special because (apparently) it is supported to pass arbitrary non-environment values in the triple (see discussion: https://github.com/llvm/llvm-project/pull/78655#issuecomment-1928458721).

https://github.com/llvm/llvm-project/pull/121123


More information about the cfe-commits mailing list