[clang] [clang] Do not serialize function definitions without a body (PR #121550)

Alejandro Álvarez Ayllón via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 6 00:53:20 PST 2025


================
@@ -6092,12 +6092,14 @@ void ASTWriter::WriteDeclUpdatesBlocks(ASTContext &Context,
 
       // An updated body is emitted last, so that the reader doesn't need
       // to skip over the lazy body to reach statements for other records.
-      if (Kind == UPD_CXX_ADDED_FUNCTION_DEFINITION)
-        HasUpdatedBody = true;
-      else if (Kind == UPD_CXX_ADDED_VAR_DEFINITION)
+      if (Kind == UPD_CXX_ADDED_FUNCTION_DEFINITION) {
+        assert(isa<FunctionDecl>(D) && "expected FunctionDecl");
+        HasUpdatedBody = cast<FunctionDecl>(D)->hasBody();
----------------
alejandro-alvarez-sonarsource wrote:

No problem! I want the get it right, not to rush it :D 

Changed, although I imagine you meant FunctionDefinitionInstantiated (not VariableDefinitionInstantiated)

https://github.com/llvm/llvm-project/pull/121550


More information about the cfe-commits mailing list