[clang] [Clang][AMDGPU] Stop defaulting to `one-as` for all atomic scopes (PR #120095)

Tony Tye via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 3 14:36:35 PST 2025


================
@@ -537,7 +537,11 @@ AMDGPUTargetCodeGenInfo::getLLVMSyncScopeID(const LangOptions &LangOpts,
     break;
   }
 
-  if (Ordering != llvm::AtomicOrdering::SequentiallyConsistent) {
+  // OpenCL assumes by default that atomic scopes are per-address space for
+  // non-sequentially consistent operations.
+  if (Scope >= SyncScope::OpenCLWorkGroup &&
----------------
t-tye wrote:

But with this change that is no longer the case. So is there any push back on this fix?

https://github.com/llvm/llvm-project/pull/120095


More information about the cfe-commits mailing list