[clang] [clang][analyzer] Stable order for SymbolRef-keyed containers (PR #121551)

[LLVM Continuous Integration via cfe-commits]

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `polly-x86_64-linux-shared-plugin` running on `polly-x86_64-gce2` while building `clang` at step 5 "build".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/118/builds/4016

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 5 (build) failure: 'ninja' (failure)
...
[90/483] Creating library symlink lib/libLLVMExecutionEngine.so
[91/483] Linking CXX shared library lib/libLLVMInterpreter.so.20.0git
[92/483] Creating library symlink lib/libLLVMInterpreter.so
[93/483] Linking CXX shared library lib/libLLVMMCJIT.so.20.0git
[94/483] Creating library symlink lib/libLLVMMCJIT.so
[95/483] Linking CXX shared library lib/libLLVMX86CodeGen.so.20.0git
[96/483] Creating library symlink lib/libLLVMX86CodeGen.so
[97/483] Linking CXX shared library lib/libLLVMSandboxIR.so.20.0git
[98/483] Creating library symlink lib/libLLVMSandboxIR.so
[99/483] Building CXX object tools/clang/lib/StaticAnalyzer/Core/CMakeFiles/obj.clangStaticAnalyzerCore.dir/AnalyzerOptions.cpp.o
FAILED: tools/clang/lib/StaticAnalyzer/Core/CMakeFiles/obj.clangStaticAnalyzerCore.dir/AnalyzerOptions.cpp.o 
ccache /usr/bin/c++ -DCLANG_EXPORTS -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/worker/buildbot-workers/polly-x86_64-gce2/rundir/llvm.obj/tools/clang/lib/StaticAnalyzer/Core -I/home/worker/buildbot-workers/polly-x86_64-gce2/rundir/llvm.src/clang/lib/StaticAnalyzer/Core -I/home/worker/buildbot-workers/polly-x86_64-gce2/rundir/llvm.src/clang/include -I/home/worker/buildbot-workers/polly-x86_64-gce2/rundir/llvm.obj/tools/clang/include -I/home/worker/buildbot-workers/polly-x86_64-gce2/rundir/llvm.obj/include -I/home/worker/buildbot-workers/polly-x86_64-gce2/rundir/llvm.src/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -fno-lifetime-dse -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -fno-common -Woverloaded-virtual -fno-strict-aliasing -O3 -DNDEBUG  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -std=c++17 -MD -MT tools/clang/lib/StaticAnalyzer/Core/CMakeFiles/obj.clangStaticAnalyzerCore.dir/AnalyzerOptions.cpp.o -MF tools/clang/lib/StaticAnalyzer/Core/CMakeFiles/obj.clangStaticAnalyzerCore.dir/AnalyzerOptions.cpp.o.d -o tools/clang/lib/StaticAnalyzer/Core/CMakeFiles/obj.clangStaticAnalyzerCore.dir/AnalyzerOptions.cpp.o -c /home/worker/buildbot-workers/polly-x86_64-gce2/rundir/llvm.src/clang/lib/StaticAnalyzer/Core/AnalyzerOptions.cpp
In file included from /home/worker/buildbot-workers/polly-x86_64-gce2/rundir/llvm.src/clang/include/clang/StaticAnalyzer/Core/PathSensitive/SValBuilder.h:29,
                 from /home/worker/buildbot-workers/polly-x86_64-gce2/rundir/llvm.src/clang/include/clang/StaticAnalyzer/Core/PathSensitive/Store.h:19,
                 from /home/worker/buildbot-workers/polly-x86_64-gce2/rundir/llvm.src/clang/include/clang/StaticAnalyzer/Core/CheckerManager.h:20,
                 from /home/worker/buildbot-workers/polly-x86_64-gce2/rundir/llvm.src/clang/include/clang/StaticAnalyzer/Core/Checker.h:18,
                 from /home/worker/buildbot-workers/polly-x86_64-gce2/rundir/llvm.src/clang/lib/StaticAnalyzer/Core/AnalyzerOptions.cpp:15:
/home/worker/buildbot-workers/polly-x86_64-gce2/rundir/llvm.src/clang/include/clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h:721:5: error: global qualification of class name is invalid before ‘:’ token
  721 |     : public ImutProfileInfo<clang::ento::SymbolRef> {
      |     ^
/home/worker/buildbot-workers/polly-x86_64-gce2/rundir/llvm.src/clang/include/clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h:721:5: error: expected ‘{’ before ‘:’ token
[100/483] Linking CXX shared library lib/libLLVMVectorize.so.20.0git
[101/483] Building CXX object tools/clang/lib/StaticAnalyzer/Core/CMakeFiles/obj.clangStaticAnalyzerCore.dir/AnalysisManager.cpp.o
FAILED: tools/clang/lib/StaticAnalyzer/Core/CMakeFiles/obj.clangStaticAnalyzerCore.dir/AnalysisManager.cpp.o 
ccache /usr/bin/c++ -DCLANG_EXPORTS -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/worker/buildbot-workers/polly-x86_64-gce2/rundir/llvm.obj/tools/clang/lib/StaticAnalyzer/Core -I/home/worker/buildbot-workers/polly-x86_64-gce2/rundir/llvm.src/clang/lib/StaticAnalyzer/Core -I/home/worker/buildbot-workers/polly-x86_64-gce2/rundir/llvm.src/clang/include -I/home/worker/buildbot-workers/polly-x86_64-gce2/rundir/llvm.obj/tools/clang/include -I/home/worker/buildbot-workers/polly-x86_64-gce2/rundir/llvm.obj/include -I/home/worker/buildbot-workers/polly-x86_64-gce2/rundir/llvm.src/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -fno-lifetime-dse -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -fno-common -Woverloaded-virtual -fno-strict-aliasing -O3 -DNDEBUG  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -std=c++17 -MD -MT tools/clang/lib/StaticAnalyzer/Core/CMakeFiles/obj.clangStaticAnalyzerCore.dir/AnalysisManager.cpp.o -MF tools/clang/lib/StaticAnalyzer/Core/CMakeFiles/obj.clangStaticAnalyzerCore.dir/AnalysisManager.cpp.o.d -o tools/clang/lib/StaticAnalyzer/Core/CMakeFiles/obj.clangStaticAnalyzerCore.dir/AnalysisManager.cpp.o -c /home/worker/buildbot-workers/polly-x86_64-gce2/rundir/llvm.src/clang/lib/StaticAnalyzer/Core/AnalysisManager.cpp
In file included from /home/worker/buildbot-workers/polly-x86_64-gce2/rundir/llvm.src/clang/include/clang/StaticAnalyzer/Core/PathSensitive/SValBuilder.h:29,
                 from /home/worker/buildbot-workers/polly-x86_64-gce2/rundir/llvm.src/clang/include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h:21,
                 from /home/worker/buildbot-workers/polly-x86_64-gce2/rundir/llvm.src/clang/include/clang/StaticAnalyzer/Core/PathSensitive/RangedConstraintManager.h:16,
                 from /home/worker/buildbot-workers/polly-x86_64-gce2/rundir/llvm.src/clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitors.h:19,
                 from /home/worker/buildbot-workers/polly-x86_64-gce2/rundir/llvm.src/clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h:21,
                 from /home/worker/buildbot-workers/polly-x86_64-gce2/rundir/llvm.src/clang/include/clang/StaticAnalyzer/Core/PathSensitive/AnalysisManager.h:21,
                 from /home/worker/buildbot-workers/polly-x86_64-gce2/rundir/llvm.src/clang/lib/StaticAnalyzer/Core/AnalysisManager.cpp:9:
/home/worker/buildbot-workers/polly-x86_64-gce2/rundir/llvm.src/clang/include/clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h:721:5: error: global qualification of class name is invalid before ‘:’ token
  721 |     : public ImutProfileInfo<clang::ento::SymbolRef> {
      |     ^
/home/worker/buildbot-workers/polly-x86_64-gce2/rundir/llvm.src/clang/include/clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h:721:5: error: expected ‘{’ before ‘:’ token
ninja: build stopped: subcommand failed.

```

</details>

https://github.com/llvm/llvm-project/pull/121551