[clang] [clang][analyzer] Stable order for SymbolRef-keyed containers (PR #121551)

[LLVM Continuous Integration via cfe-commits]

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `arc-builder` running on `arc-worker` while building `clang` at step 5 "build-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/3/builds/9825

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 5 (build-unified-tree) failure: build (failure)
0.026 [282/16/1] Generating VCSRevision.h
0.038 [281/16/2] Generating VCSVersion.inc
3.176 [280/16/3] Building CXX object tools/llvm-config/CMakeFiles/llvm-config.dir/llvm-config.cpp.o
7.945 [279/16/4] Building CXX object tools/clang/lib/StaticAnalyzer/Core/CMakeFiles/obj.clangStaticAnalyzerCore.dir/BasicValueFactory.cpp.o
FAILED: tools/clang/lib/StaticAnalyzer/Core/CMakeFiles/obj.clangStaticAnalyzerCore.dir/BasicValueFactory.cpp.o 
/usr/bin/c++ -DCLANG_EXPORTS -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Itools/clang/lib/StaticAnalyzer/Core -I/buildbot/worker/arc-folder/llvm-project/clang/lib/StaticAnalyzer/Core -I/buildbot/worker/arc-folder/llvm-project/clang/include -Itools/clang/include -Iinclude -I/buildbot/worker/arc-folder/llvm-project/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -fno-lifetime-dse -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections -fno-common -Woverloaded-virtual -fno-strict-aliasing -O3 -DNDEBUG  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -std=c++17 -MD -MT tools/clang/lib/StaticAnalyzer/Core/CMakeFiles/obj.clangStaticAnalyzerCore.dir/BasicValueFactory.cpp.o -MF tools/clang/lib/StaticAnalyzer/Core/CMakeFiles/obj.clangStaticAnalyzerCore.dir/BasicValueFactory.cpp.o.d -o tools/clang/lib/StaticAnalyzer/Core/CMakeFiles/obj.clangStaticAnalyzerCore.dir/BasicValueFactory.cpp.o -c /buildbot/worker/arc-folder/llvm-project/clang/lib/StaticAnalyzer/Core/BasicValueFactory.cpp
In file included from /buildbot/worker/arc-folder/llvm-project/clang/include/clang/StaticAnalyzer/Core/PathSensitive/SValBuilder.h:29,
                 from /buildbot/worker/arc-folder/llvm-project/clang/include/clang/StaticAnalyzer/Core/PathSensitive/Store.h:19,
                 from /buildbot/worker/arc-folder/llvm-project/clang/lib/StaticAnalyzer/Core/BasicValueFactory.cpp:18:
/buildbot/worker/arc-folder/llvm-project/clang/include/clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h:721:5: error: global qualification of class name is invalid before ':' token
  721 |     : public ImutProfileInfo<clang::ento::SymbolRef> {
      |     ^
/buildbot/worker/arc-folder/llvm-project/clang/include/clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h:721:5: error: expected '{' before ':' token
/buildbot/worker/arc-folder/llvm-project/clang/include/clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h:744:2: warning: extra ';' [-Wpedantic]
  744 | };
      |  ^
8.019 [279/15/5] Building CXX object lib/Object/CMakeFiles/LLVMObject.dir/IRSymtab.cpp.o
8.079 [279/14/6] Building CXX object tools/clang/lib/StaticAnalyzer/Core/CMakeFiles/obj.clangStaticAnalyzerCore.dir/Checker.cpp.o
FAILED: tools/clang/lib/StaticAnalyzer/Core/CMakeFiles/obj.clangStaticAnalyzerCore.dir/Checker.cpp.o 
/usr/bin/c++ -DCLANG_EXPORTS -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Itools/clang/lib/StaticAnalyzer/Core -I/buildbot/worker/arc-folder/llvm-project/clang/lib/StaticAnalyzer/Core -I/buildbot/worker/arc-folder/llvm-project/clang/include -Itools/clang/include -Iinclude -I/buildbot/worker/arc-folder/llvm-project/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -fno-lifetime-dse -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections -fno-common -Woverloaded-virtual -fno-strict-aliasing -O3 -DNDEBUG  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -std=c++17 -MD -MT tools/clang/lib/StaticAnalyzer/Core/CMakeFiles/obj.clangStaticAnalyzerCore.dir/Checker.cpp.o -MF tools/clang/lib/StaticAnalyzer/Core/CMakeFiles/obj.clangStaticAnalyzerCore.dir/Checker.cpp.o.d -o tools/clang/lib/StaticAnalyzer/Core/CMakeFiles/obj.clangStaticAnalyzerCore.dir/Checker.cpp.o -c /buildbot/worker/arc-folder/llvm-project/clang/lib/StaticAnalyzer/Core/Checker.cpp
In file included from /buildbot/worker/arc-folder/llvm-project/clang/include/clang/StaticAnalyzer/Core/PathSensitive/SValBuilder.h:29,
                 from /buildbot/worker/arc-folder/llvm-project/clang/include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h:21,
                 from /buildbot/worker/arc-folder/llvm-project/clang/lib/StaticAnalyzer/Core/Checker.cpp:13:
/buildbot/worker/arc-folder/llvm-project/clang/include/clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h:721:5: error: global qualification of class name is invalid before ':' token
  721 |     : public ImutProfileInfo<clang::ento::SymbolRef> {
      |     ^
/buildbot/worker/arc-folder/llvm-project/clang/include/clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h:721:5: error: expected '{' before ':' token
/buildbot/worker/arc-folder/llvm-project/clang/include/clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h:744:2: warning: extra ';' [-Wpedantic]
  744 | };
      |  ^
8.750 [279/13/7] Building CXX object tools/clang/lib/StaticAnalyzer/Core/CMakeFiles/obj.clangStaticAnalyzerCore.dir/AnalyzerOptions.cpp.o
FAILED: tools/clang/lib/StaticAnalyzer/Core/CMakeFiles/obj.clangStaticAnalyzerCore.dir/AnalyzerOptions.cpp.o 
/usr/bin/c++ -DCLANG_EXPORTS -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Itools/clang/lib/StaticAnalyzer/Core -I/buildbot/worker/arc-folder/llvm-project/clang/lib/StaticAnalyzer/Core -I/buildbot/worker/arc-folder/llvm-project/clang/include -Itools/clang/include -Iinclude -I/buildbot/worker/arc-folder/llvm-project/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -fno-lifetime-dse -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections -fno-common -Woverloaded-virtual -fno-strict-aliasing -O3 -DNDEBUG  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -std=c++17 -MD -MT tools/clang/lib/StaticAnalyzer/Core/CMakeFiles/obj.clangStaticAnalyzerCore.dir/AnalyzerOptions.cpp.o -MF tools/clang/lib/StaticAnalyzer/Core/CMakeFiles/obj.clangStaticAnalyzerCore.dir/AnalyzerOptions.cpp.o.d -o tools/clang/lib/StaticAnalyzer/Core/CMakeFiles/obj.clangStaticAnalyzerCore.dir/AnalyzerOptions.cpp.o -c /buildbot/worker/arc-folder/llvm-project/clang/lib/StaticAnalyzer/Core/AnalyzerOptions.cpp
In file included from /buildbot/worker/arc-folder/llvm-project/clang/include/clang/StaticAnalyzer/Core/PathSensitive/SValBuilder.h:29,
                 from /buildbot/worker/arc-folder/llvm-project/clang/include/clang/StaticAnalyzer/Core/PathSensitive/Store.h:19,
                 from /buildbot/worker/arc-folder/llvm-project/clang/include/clang/StaticAnalyzer/Core/CheckerManager.h:20,
                 from /buildbot/worker/arc-folder/llvm-project/clang/include/clang/StaticAnalyzer/Core/Checker.h:18,
                 from /buildbot/worker/arc-folder/llvm-project/clang/lib/StaticAnalyzer/Core/AnalyzerOptions.cpp:15:
/buildbot/worker/arc-folder/llvm-project/clang/include/clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h:721:5: error: global qualification of class name is invalid before ':' token
  721 |     : public ImutProfileInfo<clang::ento::SymbolRef> {
      |     ^
/buildbot/worker/arc-folder/llvm-project/clang/include/clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h:721:5: error: expected '{' before ':' token
/buildbot/worker/arc-folder/llvm-project/clang/include/clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h:744:2: warning: extra ';' [-Wpedantic]
  744 | };
      |  ^
10.804 [279/12/8] Building CXX object tools/clang/lib/StaticAnalyzer/Core/CMakeFiles/obj.clangStaticAnalyzerCore.dir/CheckerHelpers.cpp.o
FAILED: tools/clang/lib/StaticAnalyzer/Core/CMakeFiles/obj.clangStaticAnalyzerCore.dir/CheckerHelpers.cpp.o 
/usr/bin/c++ -DCLANG_EXPORTS -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Itools/clang/lib/StaticAnalyzer/Core -I/buildbot/worker/arc-folder/llvm-project/clang/lib/StaticAnalyzer/Core -I/buildbot/worker/arc-folder/llvm-project/clang/include -Itools/clang/include -Iinclude -I/buildbot/worker/arc-folder/llvm-project/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -fno-lifetime-dse -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections -fno-common -Woverloaded-virtual -fno-strict-aliasing -O3 -DNDEBUG  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -std=c++17 -MD -MT tools/clang/lib/StaticAnalyzer/Core/CMakeFiles/obj.clangStaticAnalyzerCore.dir/CheckerHelpers.cpp.o -MF tools/clang/lib/StaticAnalyzer/Core/CMakeFiles/obj.clangStaticAnalyzerCore.dir/CheckerHelpers.cpp.o.d -o tools/clang/lib/StaticAnalyzer/Core/CMakeFiles/obj.clangStaticAnalyzerCore.dir/CheckerHelpers.cpp.o -c /buildbot/worker/arc-folder/llvm-project/clang/lib/StaticAnalyzer/Core/CheckerHelpers.cpp
In file included from /buildbot/worker/arc-folder/llvm-project/clang/include/clang/StaticAnalyzer/Core/PathSensitive/SValBuilder.h:29,
                 from /buildbot/worker/arc-folder/llvm-project/clang/include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h:21,

```

</details>

https://github.com/llvm/llvm-project/pull/121551