[clang] [Clang][P1061] Add stuctured binding packs (PR #121417)

Younan Zhang via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 2 21:56:34 PST 2025


================
@@ -422,8 +445,8 @@ Sema::DiagnoseUnexpandedParameterPacks(SourceLocation Loc,
     if (const TemplateTypeParmType *TTP
           = Unexpanded[I].first.dyn_cast<const TemplateTypeParmType *>())
       Name = TTP->getIdentifier();
-    else
-      Name = cast<NamedDecl *>(Unexpanded[I].first)->getIdentifier();
+    else if (NamedDecl *ND = Unexpanded[I].first.dyn_cast<NamedDecl *>())
+      Name = ND->getIdentifier();
----------------
zyn0217 wrote:

But that also makes it confusing as to this implementation - I suggest avoiding unrelated changes for better clarity and safety. WDYT?

https://github.com/llvm/llvm-project/pull/121417


More information about the cfe-commits mailing list