[clang] [Clang] emit -Wignored-qualifiers diagnostic for cv-qualified base classes (PR #121419)

Mariya Podchishchaeva via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 2 06:32:06 PST 2025


================
@@ -2655,6 +2655,15 @@ CXXBaseSpecifier *Sema::CheckBaseSpecifier(CXXRecordDecl *Class,
       return nullptr;
     }
 
+    if (BaseType.hasQualifiers() && !isa<SubstTemplateTypeParmType>(BaseType)) {
+      auto Quals =
----------------
Fznamznon wrote:

NIT: could you please spell out the type here?
It is understandable that result is some kind of a string, however it is unclear whether it is a StringRef or a std::string, for example.

https://github.com/llvm/llvm-project/pull/121419


More information about the cfe-commits mailing list