[clang-tools-extra] [clang-tidy] swap cppcoreguidelines-narrowing-conversions and bugprone-narrowing-conversions (PR #120245)

Sun Dec 29 03:25:27 PST 2024

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `clang-ppc64le-linux-multistage` running on `ppc64le-clang-multistage-test` while building `clang-tools-extra` at step 4 "build stage 1".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/76/builds/5688

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 4 (build stage 1) failure: 'ninja' (failure)
...
[5643/6211] Creating library symlink lib/libclangTidyReadabilityModule.so
[5644/6211] Linking CXX shared library lib/libclangTidyLLVMModule.so.20.0git
[5645/6211] Creating library symlink lib/libclangTidyLLVMModule.so
[5646/6211] Linking CXX shared library lib/libclangTidyGoogleModule.so.20.0git
[5647/6211] Creating library symlink lib/libclangTidyGoogleModule.so
[5648/6211] Linking CXX shared library lib/libclangTidyFuchsiaModule.so.20.0git
[5649/6211] Creating library symlink lib/libclangTidyFuchsiaModule.so
[5650/6211] Linking CXX shared library lib/libclangTidyModernizeModule.so.20.0git
[5651/6211] Creating library symlink lib/libclangTidyModernizeModule.so
[5652/6211] Linking CXX shared library lib/libclangTidyCppCoreGuidelinesModule.so.20.0git
FAILED: lib/libclangTidyCppCoreGuidelinesModule.so.20.0git 
: && /usr/lib64/ccache/c++ -fPIC -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -fno-lifetime-dse -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wno-comment -Wno-misleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections -fno-common -Woverloaded-virtual -fno-strict-aliasing -O3 -DNDEBUG  -Wl,-z,defs -Wl,-z,nodelete   -Wl,-rpath-link,/home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-multistage-test/clang-ppc64le-multistage/stage1/./lib  -Wl,--gc-sections -shared -Wl,-soname,libclangTidyCppCoreGuidelinesModule.so.20.0git -o lib/libclangTidyCppCoreGuidelinesModule.so.20.0git tools/clang/tools/extra/clang-tidy/cppcoreguidelines/CMakeFiles/obj.clangTidyCppCoreGuidelinesModule.dir/AvoidCapturingLambdaCoroutinesCheck.cpp.o tools/clang/tools/extra/clang-tidy/cppcoreguidelines/CMakeFiles/obj.clangTidyCppCoreGuidelinesModule.dir/AvoidConstOrRefDataMembersCheck.cpp.o tools/clang/tools/extra/clang-tidy/cppcoreguidelines/CMakeFiles/obj.clangTidyCppCoreGuidelinesModule.dir/AvoidDoWhileCheck.cpp.o tools/clang/tools/extra/clang-tidy/cppcoreguidelines/CMakeFiles/obj.clangTidyCppCoreGuidelinesModule.dir/AvoidGotoCheck.cpp.o tools/clang/tools/extra/clang-tidy/cppcoreguidelines/CMakeFiles/obj.clangTidyCppCoreGuidelinesModule.dir/AvoidNonConstGlobalVariablesCheck.cpp.o tools/clang/tools/extra/clang-tidy/cppcoreguidelines/CMakeFiles/obj.clangTidyCppCoreGuidelinesModule.dir/AvoidReferenceCoroutineParametersCheck.cpp.o tools/clang/tools/extra/clang-tidy/cppcoreguidelines/CMakeFiles/obj.clangTidyCppCoreGuidelinesModule.dir/CppCoreGuidelinesTidyModule.cpp.o tools/clang/tools/extra/clang-tidy/cppcoreguidelines/CMakeFiles/obj.clangTidyCppCoreGuidelinesModule.dir/InitVariablesCheck.cpp.o tools/clang/tools/extra/clang-tidy/cppcoreguidelines/CMakeFiles/obj.clangTidyCppCoreGuidelinesModule.dir/InterfacesGlobalInitCheck.cpp.o tools/clang/tools/extra/clang-tidy/cppcoreguidelines/CMakeFiles/obj.clangTidyCppCoreGuidelinesModule.dir/MacroUsageCheck.cpp.o tools/clang/tools/extra/clang-tidy/cppcoreguidelines/CMakeFiles/obj.clangTidyCppCoreGuidelinesModule.dir/MisleadingCaptureDefaultByValueCheck.cpp.o tools/clang/tools/extra/clang-tidy/cppcoreguidelines/CMakeFiles/obj.clangTidyCppCoreGuidelinesModule.dir/MissingStdForwardCheck.cpp.o tools/clang/tools/extra/clang-tidy/cppcoreguidelines/CMakeFiles/obj.clangTidyCppCoreGuidelinesModule.dir/NoMallocCheck.cpp.o tools/clang/tools/extra/clang-tidy/cppcoreguidelines/CMakeFiles/obj.clangTidyCppCoreGuidelinesModule.dir/NoSuspendWithLockCheck.cpp.o tools/clang/tools/extra/clang-tidy/cppcoreguidelines/CMakeFiles/obj.clangTidyCppCoreGuidelinesModule.dir/OwningMemoryCheck.cpp.o tools/clang/tools/extra/clang-tidy/cppcoreguidelines/CMakeFiles/obj.clangTidyCppCoreGuidelinesModule.dir/PreferMemberInitializerCheck.cpp.o tools/clang/tools/extra/clang-tidy/cppcoreguidelines/CMakeFiles/obj.clangTidyCppCoreGuidelinesModule.dir/ProBoundsArrayToPointerDecayCheck.cpp.o tools/clang/tools/extra/clang-tidy/cppcoreguidelines/CMakeFiles/obj.clangTidyCppCoreGuidelinesModule.dir/ProBoundsConstantArrayIndexCheck.cpp.o tools/clang/tools/extra/clang-tidy/cppcoreguidelines/CMakeFiles/obj.clangTidyCppCoreGuidelinesModule.dir/ProBoundsPointerArithmeticCheck.cpp.o tools/clang/tools/extra/clang-tidy/cppcoreguidelines/CMakeFiles/obj.clangTidyCppCoreGuidelinesModule.dir/ProTypeConstCastCheck.cpp.o tools/clang/tools/extra/clang-tidy/cppcoreguidelines/CMakeFiles/obj.clangTidyCppCoreGuidelinesModule.dir/ProTypeCstyleCastCheck.cpp.o tools/clang/tools/extra/clang-tidy/cppcoreguidelines/CMakeFiles/obj.clangTidyCppCoreGuidelinesModule.dir/ProTypeMemberInitCheck.cpp.o tools/clang/tools/extra/clang-tidy/cppcoreguidelines/CMakeFiles/obj.clangTidyCppCoreGuide
dir/ProTypeStaticCastDowncastCheck.cpp.o tools/clang/tools/extra/clang-tidy/cppcoreguidelines/CMakeFiles/obj.clangTidyCppCoreGuidelinesModule.dir/ProTypeUnionAccessCheck.cpp.o tools/clang/tools/extra/clang-tidy/cppcoreguidelines/CMakeFiles/obj.clangTidyCppCoreGuidelinesModule.dir/ProTypeVarargCheck.cpp.o tools/clang/tools/extra/clang-tidy/cppcoreguidelines/CMakeFiles/obj.clangTidyCppCoreGuidelinesModule.dir/RvalueReferenceParamNotMovedCheck.cpp.o tools/clang/tools/extra/clang-tidy/cppcoreguidelines/CMakeFiles/obj.clangTidyCppCoreGuidelinesModule.dir/SlicingCheck.cpp.o tools/clang/tools/extra/clang-tidy/cppcoreguidelines/CMakeFiles/obj.clangTidyCppCoreGuidelinesModule.dir/SpecialMemberFunctionsCheck.cpp.o tools/clang/tools/extra/clang-tidy/cppcoreguidelines/CMakeFiles/obj.clangTidyCppCoreGuidelinesModule.dir/VirtualClassDestructorCheck.cpp.o  -Wl,-rpath,"\$ORIGIN/../lib:/home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-multistage-test/clang-ppc64le-multistage/stage1/lib:"  lib/libclangTidyMiscModule.so.20.0git  lib/libclangTidyModernizeModule.so.20.0git  lib/libclangTidyPerformanceModule.so.20.0git  lib/libclangTidyReadabilityModule.so.20.0git  lib/libclangTidyUtils.so.20.0git  lib/libclangTidy.so.20.0git  lib/libclangTooling.so.20.0git  lib/libclangSerialization.so.20.0git  lib/libclangAnalysis.so.20.0git  lib/libclangASTMatchers.so.20.0git  lib/libclangAST.so.20.0git  lib/libclangLex.so.20.0git  lib/libclangBasic.so.20.0git  lib/libLLVMFrontendOpenMP.so.20.0git  lib/libLLVMSupport.so.20.0git  -Wl,-rpath-link,/home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-multistage-test/clang-ppc64le-multistage/stage1/lib && :
tools/clang/tools/extra/clang-tidy/cppcoreguidelines/CMakeFiles/obj.clangTidyCppCoreGuidelinesModule.dir/CppCoreGuidelinesTidyModule.cpp.o: In function `std::_Function_handler<std::unique_ptr<clang::tidy::ClangTidyCheck, std::default_delete<clang::tidy::ClangTidyCheck> > (llvm::StringRef, clang::tidy::ClangTidyContext*), clang::tidy::ClangTidyCheckFactories::registerCheck<clang::tidy::bugprone::NarrowingConversionsCheck>(llvm::StringRef)::{lambda(llvm::StringRef, clang::tidy::ClangTidyContext*)#1}>::_M_invoke(std::_Any_data const&, llvm::StringRef&&, clang::tidy::ClangTidyContext*&&)':
CppCoreGuidelinesTidyModule.cpp:(.text._ZNSt17_Function_handlerIFSt10unique_ptrIN5clang4tidy14ClangTidyCheckESt14default_deleteIS3_EEN4llvm9StringRefEPNS2_16ClangTidyContextEEZNS2_23ClangTidyCheckFactories13registerCheckINS2_8bugprone25NarrowingConversionsCheckEEEvS8_EUlS8_SA_E_E9_M_invokeERKSt9_Any_dataOS8_OSA_[_ZNSt17_Function_handlerIFSt10unique_ptrIN5clang4tidy14ClangTidyCheckESt14default_deleteIS3_EEN4llvm9StringRefEPNS2_16ClangTidyContextEEZNS2_23ClangTidyCheckFactories13registerCheckINS2_8bugprone25NarrowingConversionsCheckEEEvS8_EUlS8_SA_E_E9_M_invokeERKSt9_Any_dataOS8_OSA_]+0x54): undefined reference to `clang::tidy::bugprone::NarrowingConversionsCheck::NarrowingConversionsCheck(llvm::StringRef, clang::tidy::ClangTidyContext*)'
collect2: error: ld returned 1 exit status
[5653/6211] Building AMDGPUGenRegisterBank.inc...
[5654/6211] Building AMDGPUGenRegisterInfo.inc...
ninja: build stopped: subcommand failed.

```

</details>

https://github.com/llvm/llvm-project/pull/120245