[clang] [clang][Sema] Move computing enum width and type to a separate function (PR #120965)

Ilia Kuklin via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 24 04:24:27 PST 2024


================
@@ -20008,6 +20008,87 @@ bool Sema::IsValueInFlagEnum(const EnumDecl *ED, const llvm::APInt &Val,
   return !(FlagMask & Val) || (AllowMask && !(FlagMask & ~Val));
 }
 
+bool Sema::ComputeBestEnumProperties(ASTContext &Context, EnumDecl *Enum,
+                                     bool is_cpp, bool isPacked,
----------------
kuilpd wrote:

Maybe better to put this function into `EnumDecl` itself? It has `ASTContext` within it filled on both Sema and LLDB side, and then `EnumDecl`  can fill it's own `BestType` and `BestPromotionType` fields using this function. 

https://github.com/llvm/llvm-project/pull/120965


More information about the cfe-commits mailing list