[clang] [WebKit checkers] Recognize adoptRef as a safe function (PR #119846)

LLVM Continuous Integration via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 19 11:33:54 PST 2024


llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `fuchsia-x86_64-linux` running on `fuchsia-debian-64-us-central1-a-1` while building `clang` at step 4 "annotate".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/11/builds/10006

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 4 (annotate) failure: 'python ../llvm-zorg/zorg/buildbot/builders/annotated/fuchsia-linux.py ...' (failure)
...
clang++: warning: optimization flag '-ffat-lto-objects' is not supported [-Wignored-optimization-argument]
[822/1359] Running the Clang regression tests
llvm-lit: /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/utils/lit/lit/llvm/config.py:506: note: using clang: /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-hsisnj9d/bin/clang
llvm-lit: /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/utils/lit/lit/llvm/subst.py:126: note: Did not find clang-repl in /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-hsisnj9d/bin:/var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-hsisnj9d/bin
llvm-lit: /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/utils/lit/lit/llvm/config.py:506: note: using ld.lld: /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-hsisnj9d/bin/ld.lld
llvm-lit: /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/utils/lit/lit/llvm/config.py:506: note: using lld-link: /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-hsisnj9d/bin/lld-link
llvm-lit: /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/utils/lit/lit/llvm/config.py:506: note: using ld64.lld: /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-hsisnj9d/bin/ld64.lld
llvm-lit: /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/utils/lit/lit/llvm/config.py:506: note: using wasm-ld: /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-hsisnj9d/bin/wasm-ld
-- Testing: 21719 tests, 60 workers --
Testing:  0
FAIL: Clang :: Analysis/Checkers/WebKit/local-vars-counted-const-member.cpp (541 of 21719)
******************** TEST 'Clang :: Analysis/Checkers/WebKit/local-vars-counted-const-member.cpp' FAILED ********************
Exit Code: 1

Command Output (stderr):
--
RUN: at line 1: /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-hsisnj9d/bin/clang -cc1 -internal-isystem /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-hsisnj9d/lib/clang/20/include -nostdsysteminc -analyze -analyzer-constraints=range -setup-static-analyzer -analyzer-checker=alpha.webkit.UncountedLocalVarsChecker -verify /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/Analysis/Checkers/WebKit/local-vars-counted-const-member.cpp
+ /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-hsisnj9d/bin/clang -cc1 -internal-isystem /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-hsisnj9d/lib/clang/20/include -nostdsysteminc -analyze -analyzer-constraints=range -setup-static-analyzer -analyzer-checker=alpha.webkit.UncountedLocalVarsChecker -verify /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/Analysis/Checkers/WebKit/local-vars-counted-const-member.cpp
error: 'expected-error' diagnostics seen but not expected: 
  File /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/Analysis/Checkers/WebKit/local-vars-counted-const-member.cpp Line 17: object of type 'RefPtr<RefCountable>' cannot be assigned because its copy assignment operator is implicitly deleted
  File /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/Analysis/Checkers/WebKit/local-vars-counted-const-member.cpp Line 23: object of type 'RefPtr<RefCountable>' cannot be assigned because its copy assignment operator is implicitly deleted
  File /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/Analysis/Checkers/WebKit/local-vars-counted-const-member.cpp Line 33: object of type 'RefPtr<RefCountable>' cannot be assigned because its copy assignment operator is implicitly deleted
error: 'expected-warning' diagnostics expected but not seen: 
  File /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/Analysis/Checkers/WebKit/local-vars-counted-const-member.cpp Line 24 (directive at /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/Analysis/Checkers/WebKit/local-vars-counted-const-member.cpp:25): Local variable 'next' is uncounted and unsafe [alpha.webkit.UncountedLocalVarsChecker]
  File /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/Analysis/Checkers/WebKit/local-vars-counted-const-member.cpp Line 50 (directive at /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/Analysis/Checkers/WebKit/local-vars-counted-const-member.cpp:51): Local variable 'obj2' is uncounted and unsafe [alpha.webkit.UncountedLocalVarsChecker]
  File /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/Analysis/Checkers/WebKit/local-vars-counted-const-member.cpp Line 55 (directive at /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/Analysis/Checkers/WebKit/local-vars-counted-const-member.cpp:56): Local variable 'obj4' is uncounted and unsafe [alpha.webkit.UncountedLocalVarsChecker]
  File /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/Analysis/Checkers/WebKit/local-vars-counted-const-member.cpp Line 78 (directive at /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/Analysis/Checkers/WebKit/local-vars-counted-const-member.cpp:79): Local variable 'obj2' is uncounted and unsafe [alpha.webkit.UncountedLocalVarsChecker]
  File /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/Analysis/Checkers/WebKit/local-vars-counted-const-member.cpp Line 100 (directive at /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/Analysis/Checkers/WebKit/local-vars-counted-const-member.cpp:101): Local variable 'obj2' is uncounted and unsafe [alpha.webkit.UncountedLocalVarsChecker]
error: 'expected-note' diagnostics seen but not expected: 
  File /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/Analysis/Checkers/WebKit/mock-types.h Line 128: copy assignment operator is implicitly deleted because 'RefPtr<RefCountable>' has a user-declared move constructor
  File /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/Analysis/Checkers/WebKit/mock-types.h Line 128: copy assignment operator is implicitly deleted because 'RefPtr<RefCountable>' has a user-declared move constructor
  File /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/Analysis/Checkers/WebKit/mock-types.h Line 128: copy assignment operator is implicitly deleted because 'RefPtr<RefCountable>' has a user-declared move constructor
11 errors generated.

--

********************
Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90.. 
********************
Failed Tests (1):
  Clang :: Analysis/Checkers/WebKit/local-vars-counted-const-member.cpp


Testing Time: 134.66s

Total Discovered Tests: 45876
  Skipped          :     8 (0.02%)
  Unsupported      :   884 (1.93%)
  Passed           : 44956 (97.99%)
Step 7 (check) failure: check (failure)
...
clang++: warning: optimization flag '-ffat-lto-objects' is not supported [-Wignored-optimization-argument]
[822/1359] Running the Clang regression tests
llvm-lit: /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/utils/lit/lit/llvm/config.py:506: note: using clang: /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-hsisnj9d/bin/clang
llvm-lit: /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/utils/lit/lit/llvm/subst.py:126: note: Did not find clang-repl in /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-hsisnj9d/bin:/var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-hsisnj9d/bin
llvm-lit: /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/utils/lit/lit/llvm/config.py:506: note: using ld.lld: /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-hsisnj9d/bin/ld.lld
llvm-lit: /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/utils/lit/lit/llvm/config.py:506: note: using lld-link: /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-hsisnj9d/bin/lld-link
llvm-lit: /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/utils/lit/lit/llvm/config.py:506: note: using ld64.lld: /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-hsisnj9d/bin/ld64.lld
llvm-lit: /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/utils/lit/lit/llvm/config.py:506: note: using wasm-ld: /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-hsisnj9d/bin/wasm-ld
-- Testing: 21719 tests, 60 workers --
Testing:  0
FAIL: Clang :: Analysis/Checkers/WebKit/local-vars-counted-const-member.cpp (541 of 21719)
******************** TEST 'Clang :: Analysis/Checkers/WebKit/local-vars-counted-const-member.cpp' FAILED ********************
Exit Code: 1

Command Output (stderr):
--
RUN: at line 1: /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-hsisnj9d/bin/clang -cc1 -internal-isystem /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-hsisnj9d/lib/clang/20/include -nostdsysteminc -analyze -analyzer-constraints=range -setup-static-analyzer -analyzer-checker=alpha.webkit.UncountedLocalVarsChecker -verify /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/Analysis/Checkers/WebKit/local-vars-counted-const-member.cpp
+ /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-hsisnj9d/bin/clang -cc1 -internal-isystem /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-hsisnj9d/lib/clang/20/include -nostdsysteminc -analyze -analyzer-constraints=range -setup-static-analyzer -analyzer-checker=alpha.webkit.UncountedLocalVarsChecker -verify /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/Analysis/Checkers/WebKit/local-vars-counted-const-member.cpp
error: 'expected-error' diagnostics seen but not expected: 
  File /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/Analysis/Checkers/WebKit/local-vars-counted-const-member.cpp Line 17: object of type 'RefPtr<RefCountable>' cannot be assigned because its copy assignment operator is implicitly deleted
  File /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/Analysis/Checkers/WebKit/local-vars-counted-const-member.cpp Line 23: object of type 'RefPtr<RefCountable>' cannot be assigned because its copy assignment operator is implicitly deleted
  File /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/Analysis/Checkers/WebKit/local-vars-counted-const-member.cpp Line 33: object of type 'RefPtr<RefCountable>' cannot be assigned because its copy assignment operator is implicitly deleted
error: 'expected-warning' diagnostics expected but not seen: 
  File /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/Analysis/Checkers/WebKit/local-vars-counted-const-member.cpp Line 24 (directive at /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/Analysis/Checkers/WebKit/local-vars-counted-const-member.cpp:25): Local variable 'next' is uncounted and unsafe [alpha.webkit.UncountedLocalVarsChecker]
  File /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/Analysis/Checkers/WebKit/local-vars-counted-const-member.cpp Line 50 (directive at /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/Analysis/Checkers/WebKit/local-vars-counted-const-member.cpp:51): Local variable 'obj2' is uncounted and unsafe [alpha.webkit.UncountedLocalVarsChecker]
  File /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/Analysis/Checkers/WebKit/local-vars-counted-const-member.cpp Line 55 (directive at /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/Analysis/Checkers/WebKit/local-vars-counted-const-member.cpp:56): Local variable 'obj4' is uncounted and unsafe [alpha.webkit.UncountedLocalVarsChecker]
  File /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/Analysis/Checkers/WebKit/local-vars-counted-const-member.cpp Line 78 (directive at /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/Analysis/Checkers/WebKit/local-vars-counted-const-member.cpp:79): Local variable 'obj2' is uncounted and unsafe [alpha.webkit.UncountedLocalVarsChecker]
  File /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/Analysis/Checkers/WebKit/local-vars-counted-const-member.cpp Line 100 (directive at /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/Analysis/Checkers/WebKit/local-vars-counted-const-member.cpp:101): Local variable 'obj2' is uncounted and unsafe [alpha.webkit.UncountedLocalVarsChecker]
error: 'expected-note' diagnostics seen but not expected: 
  File /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/Analysis/Checkers/WebKit/mock-types.h Line 128: copy assignment operator is implicitly deleted because 'RefPtr<RefCountable>' has a user-declared move constructor
  File /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/Analysis/Checkers/WebKit/mock-types.h Line 128: copy assignment operator is implicitly deleted because 'RefPtr<RefCountable>' has a user-declared move constructor
  File /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/Analysis/Checkers/WebKit/mock-types.h Line 128: copy assignment operator is implicitly deleted because 'RefPtr<RefCountable>' has a user-declared move constructor
11 errors generated.

--

********************
Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90.. 
********************
Failed Tests (1):
  Clang :: Analysis/Checkers/WebKit/local-vars-counted-const-member.cpp


Testing Time: 134.66s

Total Discovered Tests: 45876
  Skipped          :     8 (0.02%)
  Unsupported      :   884 (1.93%)
  Passed           : 44956 (97.99%)

```

</details>

https://github.com/llvm/llvm-project/pull/119846


More information about the cfe-commits mailing list