[clang] [clang] Restrict use of scalar types in vector builtins (PR #119423)

Eli Friedman via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 18 13:37:10 PST 2024


================
@@ -14585,11 +14585,18 @@ void Sema::CheckAddressOfPackedMember(Expr *rhs) {
                      _2, _3, _4));
 }
 
+static ExprResult UsualUnaryConversionsNoPromoteInt(Sema &S, Expr *E) {
+  // Don't promote integer types
+  if (QualType Ty = E->getType(); S.getASTContext().isPromotableIntegerType(Ty))
+    return S.DefaultFunctionArrayLvalueConversion(E);
+  return S.UsualUnaryConversions(E);
----------------
efriedma-quic wrote:

If I'm following correctly, this specifically skips promoting integers... but it allows promoting floats?  I think I'd prefer to factor out the unary-float conversions into a separate function, and call that here, for clarity.

https://github.com/llvm/llvm-project/pull/119423


More information about the cfe-commits mailing list