[clang] [SYCL] Basic diagnostics for the sycl_kernel_entry_point attribute. (PR #120327)

Erich Keane via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 18 06:57:49 PST 2024


================
@@ -15978,6 +15988,24 @@ Decl *Sema::ActOnFinishFunctionBody(Decl *dcl, Stmt *Body,
       CheckCoroutineWrapper(FD);
   }
 
+  // Diagnose invalid SYCL kernel entry point function declarations.
+  if (FD && !FD->isInvalidDecl() && !FD->isTemplated() &&
----------------
erichkeane wrote:

Why `isTemplated`? All of these things look like rules you can check even on a dependent function, right? Also, 'isTemplated' just means one of its parents is at template, so in the case of a 'friend' this could actually be defined/declared even without the template being instantiated.


https://github.com/llvm/llvm-project/pull/120327


More information about the cfe-commits mailing list