[clang] 5a5838f - Introduce CounterMappingRegion::isBranch(). NFC.

NAKAMURA Takumi via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 18 03:00:19 PST 2024


Author: NAKAMURA Takumi
Date: 2024-12-18T20:00:02+09:00
New Revision: 5a5838fba37153adb7885c897131dda09227eb2d

URL: https://github.com/llvm/llvm-project/commit/5a5838fba37153adb7885c897131dda09227eb2d
DIFF: https://github.com/llvm/llvm-project/commit/5a5838fba37153adb7885c897131dda09227eb2d.diff

LOG: Introduce CounterMappingRegion::isBranch(). NFC.

Added: 
    

Modified: 
    clang/lib/CodeGen/CoverageMappingGen.cpp
    llvm/include/llvm/ProfileData/Coverage/CoverageMapping.h

Removed: 
    


################################################################################
diff  --git a/clang/lib/CodeGen/CoverageMappingGen.cpp b/clang/lib/CodeGen/CoverageMappingGen.cpp
index 96c89b2728e5b7..7248abe480cba8 100644
--- a/clang/lib/CodeGen/CoverageMappingGen.cpp
+++ b/clang/lib/CodeGen/CoverageMappingGen.cpp
@@ -2370,8 +2370,7 @@ static void dump(llvm::raw_ostream &OS, StringRef FunctionName,
     } else {
       Ctx.dump(R.Count, OS);
 
-      if (R.Kind == CounterMappingRegion::BranchRegion ||
-          R.Kind == CounterMappingRegion::MCDCBranchRegion) {
+      if (R.isBranch()) {
         OS << ", ";
         Ctx.dump(R.FalseCount, OS);
       }

diff  --git a/llvm/include/llvm/ProfileData/Coverage/CoverageMapping.h b/llvm/include/llvm/ProfileData/Coverage/CoverageMapping.h
index 590185d42e72a6..42da188fef34ee 100644
--- a/llvm/include/llvm/ProfileData/Coverage/CoverageMapping.h
+++ b/llvm/include/llvm/ProfileData/Coverage/CoverageMapping.h
@@ -272,6 +272,10 @@ struct CounterMappingRegion {
 
   RegionKind Kind;
 
+  bool isBranch() const {
+    return (Kind == BranchRegion || Kind == MCDCBranchRegion);
+  }
+
   CounterMappingRegion(Counter Count, unsigned FileID, unsigned ExpandedFileID,
                        unsigned LineStart, unsigned ColumnStart,
                        unsigned LineEnd, unsigned ColumnEnd, RegionKind Kind)
@@ -716,8 +720,7 @@ struct FunctionRecord {
 
   void pushRegion(CounterMappingRegion Region, uint64_t Count,
                   uint64_t FalseCount, bool HasSingleByteCoverage) {
-    if (Region.Kind == CounterMappingRegion::BranchRegion ||
-        Region.Kind == CounterMappingRegion::MCDCBranchRegion) {
+    if (Region.isBranch()) {
       CountedBranchRegions.emplace_back(Region, Count, FalseCount,
                                         HasSingleByteCoverage);
       // If either counter is hard-coded to zero, then this region represents a


        


More information about the cfe-commits mailing list