[clang] [NFC][Clang] Fix static analyzer concerns (PR #120259)

via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 17 08:21:59 PST 2024


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-clang

Author: Mariya Podchishchaeva (Fznamznon)

<details>
<summary>Changes</summary>

Remove unnecessary checks since they are checking that an unsigned number >= 0, which is always true.

---
Full diff: https://github.com/llvm/llvm-project/pull/120259.diff


2 Files Affected:

- (modified) clang/lib/Basic/Targets/AMDGPU.h (-1) 
- (modified) clang/lib/Basic/Targets/NVPTX.h (-1) 


``````````diff
diff --git a/clang/lib/Basic/Targets/AMDGPU.h b/clang/lib/Basic/Targets/AMDGPU.h
index ea4189cdea47da..e3f0375315ad0c 100644
--- a/clang/lib/Basic/Targets/AMDGPU.h
+++ b/clang/lib/Basic/Targets/AMDGPU.h
@@ -119,7 +119,6 @@ class LLVM_LIBRARY_VISIBILITY AMDGPUTargetInfo final : public TargetInfo {
              (isTargetAddressSpace(A) &&
               toTargetAddressSpace(A) == llvm::AMDGPUAS::FLAT_ADDRESS)) &&
             isTargetAddressSpace(B) &&
-            toTargetAddressSpace(B) >= llvm::AMDGPUAS::FLAT_ADDRESS &&
             toTargetAddressSpace(B) <= llvm::AMDGPUAS::PRIVATE_ADDRESS &&
             toTargetAddressSpace(B) != llvm::AMDGPUAS::REGION_ADDRESS);
   }
diff --git a/clang/lib/Basic/Targets/NVPTX.h b/clang/lib/Basic/Targets/NVPTX.h
index d81b89a7f24ac0..b2f2447917e324 100644
--- a/clang/lib/Basic/Targets/NVPTX.h
+++ b/clang/lib/Basic/Targets/NVPTX.h
@@ -99,7 +99,6 @@ class LLVM_LIBRARY_VISIBILITY NVPTXTargetInfo : public TargetInfo {
               toTargetAddressSpace(A) ==
                   llvm::NVPTXAS::ADDRESS_SPACE_GENERIC)) &&
             isTargetAddressSpace(B) &&
-            toTargetAddressSpace(B) >= llvm::NVPTXAS::ADDRESS_SPACE_GENERIC &&
             toTargetAddressSpace(B) <= llvm::NVPTXAS::ADDRESS_SPACE_LOCAL &&
             toTargetAddressSpace(B) != 2);
   }

``````````

</details>


https://github.com/llvm/llvm-project/pull/120259


More information about the cfe-commits mailing list