[clang] e5a6f1c - [NFC][webkit.UncountedLambdaCapturesChecker] Remove unnecessary check (#120069)

via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 17 01:45:15 PST 2024


Author: Mariya Podchishchaeva
Date: 2024-12-17T10:45:10+01:00
New Revision: e5a6f1c7793408adfe299c8fa5f4a53e236076b5

URL: https://github.com/llvm/llvm-project/commit/e5a6f1c7793408adfe299c8fa5f4a53e236076b5
DIFF: https://github.com/llvm/llvm-project/commit/e5a6f1c7793408adfe299c8fa5f4a53e236076b5.diff

LOG: [NFC][webkit.UncountedLambdaCapturesChecker] Remove unnecessary check (#120069)

CXXMD is checked for null, but it can't be null inside of a visitor's
method. Found by a static analyzer tool.

Added: 
    

Modified: 
    clang/lib/StaticAnalyzer/Checkers/WebKit/UncountedLambdaCapturesChecker.cpp

Removed: 
    


################################################################################
diff  --git a/clang/lib/StaticAnalyzer/Checkers/WebKit/UncountedLambdaCapturesChecker.cpp b/clang/lib/StaticAnalyzer/Checkers/WebKit/UncountedLambdaCapturesChecker.cpp
index ac5cf3d899d55a..d786b02e2d7f3a 100644
--- a/clang/lib/StaticAnalyzer/Checkers/WebKit/UncountedLambdaCapturesChecker.cpp
+++ b/clang/lib/StaticAnalyzer/Checkers/WebKit/UncountedLambdaCapturesChecker.cpp
@@ -52,7 +52,7 @@ class UncountedLambdaCapturesChecker
 
       bool TraverseCXXMethodDecl(CXXMethodDecl *CXXMD) override {
         llvm::SaveAndRestore SavedDecl(ClsType);
-        if (CXXMD && CXXMD->isInstance())
+        if (CXXMD->isInstance())
           ClsType = CXXMD->getThisType();
         return DynamicRecursiveASTVisitor::TraverseCXXMethodDecl(CXXMD);
       }


        


More information about the cfe-commits mailing list