[clang] Revert "[Static analysis] Encodes a filename before inserting it into a URL." (PR #120195)

via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 16 23:36:46 PST 2024


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-clang

Author: Ryosuke Niwa (rniwa)

<details>
<summary>Changes</summary>

Reverts llvm/llvm-project#<!-- -->120123
Broke some tests.

---
Full diff: https://github.com/llvm/llvm-project/pull/120195.diff


1 Files Affected:

- (modified) clang/tools/scan-build/bin/scan-build (+1-3) 


``````````diff
diff --git a/clang/tools/scan-build/bin/scan-build b/clang/tools/scan-build/bin/scan-build
index 1df043ef8b72bd..37241c6d85c5b2 100755
--- a/clang/tools/scan-build/bin/scan-build
+++ b/clang/tools/scan-build/bin/scan-build
@@ -23,7 +23,6 @@ use Term::ANSIColor qw(:constants);
 use Cwd qw/ getcwd abs_path /;
 use Sys::Hostname;
 use Hash::Util qw(lock_keys);
-use URI::Escape;
 
 my $Prog = "scan-build";
 my $BuildName;
@@ -821,8 +820,7 @@ ENDTEXT
       }
 
       # Emit the "View" link.
-      my $EncodedReport = uri_escape($ReportFile, "^A-Za-z0-9\-\._~\/");
-      print OUT "<td><a href=\"$EncodedReport#EndPath\">View Report</a></td>";
+      print OUT "<td><a href=\"$ReportFile#EndPath\">View Report</a></td>";
 
       # Emit REPORTBUG markers.
       print OUT "\n<!-- REPORTBUG id=\"$ReportFile\" -->\n";

``````````

</details>


https://github.com/llvm/llvm-project/pull/120195


More information about the cfe-commits mailing list