[clang] Revert "[Static analysis] Encodes a filename before inserting it into a URL." (PR #120195)

Ryosuke Niwa via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 16 23:36:12 PST 2024


https://github.com/rniwa created https://github.com/llvm/llvm-project/pull/120195

Reverts llvm/llvm-project#120123
Broke some tests.

>From b2b261c406108390117e1b6c3fdbe5e9d53a7111 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa <ryosuke.niwa at gmail.com>
Date: Mon, 16 Dec 2024 23:35:54 -0800
Subject: [PATCH] =?UTF-8?q?Revert=20"[Static=20analysis]=20Encodes=20a=20f?=
 =?UTF-8?q?ilename=20before=20inserting=20it=20into=20a=20URL.=20=E2=80=A6?=
 =?UTF-8?q?"?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

This reverts commit f515d7aa720142dfbb72f52e9d0106ba33e1fe69.
---
 clang/tools/scan-build/bin/scan-build | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/clang/tools/scan-build/bin/scan-build b/clang/tools/scan-build/bin/scan-build
index 1df043ef8b72bd..37241c6d85c5b2 100755
--- a/clang/tools/scan-build/bin/scan-build
+++ b/clang/tools/scan-build/bin/scan-build
@@ -23,7 +23,6 @@ use Term::ANSIColor qw(:constants);
 use Cwd qw/ getcwd abs_path /;
 use Sys::Hostname;
 use Hash::Util qw(lock_keys);
-use URI::Escape;
 
 my $Prog = "scan-build";
 my $BuildName;
@@ -821,8 +820,7 @@ ENDTEXT
       }
 
       # Emit the "View" link.
-      my $EncodedReport = uri_escape($ReportFile, "^A-Za-z0-9\-\._~\/");
-      print OUT "<td><a href=\"$EncodedReport#EndPath\">View Report</a></td>";
+      print OUT "<td><a href=\"$ReportFile#EndPath\">View Report</a></td>";
 
       # Emit REPORTBUG markers.
       print OUT "\n<!-- REPORTBUG id=\"$ReportFile\" -->\n";



More information about the cfe-commits mailing list