[clang] [Clang] Fix crash in __builtin_assume_aligned (PR #114217)

[Eli Friedman via cfe-commits]

================
@@ -5272,8 +5272,11 @@ bool Sema::BuiltinAssumeAligned(CallExpr *TheCall) {
   {
     ExprResult FirstArgResult =
         DefaultFunctionArrayLvalueConversion(FirstArg);
-    if (checkBuiltinArgument(*this, TheCall, 0))
----------------
efriedma-quic wrote:

Took another look at this... probably this is okay.  checkBuiltinArgument isn't actually doing anything useful here, and other places do something similar with DefaultFunctionArrayLvalueConversion().

The comment about "In-place updation of FirstArg by checkBuiltinArgument" should be deleted, though.

https://github.com/llvm/llvm-project/pull/114217