[clang] [NFC][[webkit.UncountedLambdaCapturesChecker] Remove unnecessary check (PR #120069)
via cfe-commits
cfe-commits at lists.llvm.org
Mon Dec 16 04:02:00 PST 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-clang
Author: Mariya Podchishchaeva (Fznamznon)
<details>
<summary>Changes</summary>
CXXMD is checked for null, but it can't be null inside of a visitor's method. Found by a static analyzer tool.
---
Full diff: https://github.com/llvm/llvm-project/pull/120069.diff
1 Files Affected:
- (modified) clang/lib/StaticAnalyzer/Checkers/WebKit/UncountedLambdaCapturesChecker.cpp (+1-1)
``````````diff
diff --git a/clang/lib/StaticAnalyzer/Checkers/WebKit/UncountedLambdaCapturesChecker.cpp b/clang/lib/StaticAnalyzer/Checkers/WebKit/UncountedLambdaCapturesChecker.cpp
index ac5cf3d899d55a..d786b02e2d7f3a 100644
--- a/clang/lib/StaticAnalyzer/Checkers/WebKit/UncountedLambdaCapturesChecker.cpp
+++ b/clang/lib/StaticAnalyzer/Checkers/WebKit/UncountedLambdaCapturesChecker.cpp
@@ -52,7 +52,7 @@ class UncountedLambdaCapturesChecker
bool TraverseCXXMethodDecl(CXXMethodDecl *CXXMD) override {
llvm::SaveAndRestore SavedDecl(ClsType);
- if (CXXMD && CXXMD->isInstance())
+ if (CXXMD->isInstance())
ClsType = CXXMD->getThisType();
return DynamicRecursiveASTVisitor::TraverseCXXMethodDecl(CXXMD);
}
``````````
</details>
https://github.com/llvm/llvm-project/pull/120069
More information about the cfe-commits
mailing list