[clang] [NFC][[webkit.UncountedLambdaCapturesChecker] Remove unnecessary check (PR #120069)
Mariya Podchishchaeva via cfe-commits
cfe-commits at lists.llvm.org
Mon Dec 16 04:01:25 PST 2024
https://github.com/Fznamznon created https://github.com/llvm/llvm-project/pull/120069
CXXMD is checked for null, but it can't be null inside of a visitor's method. Found by a static analyzer tool.
>From af15db0dcd01cb4295771a77604e9ad7b5c3791c Mon Sep 17 00:00:00 2001
From: "Podchishchaeva, Mariya" <mariya.podchishchaeva at intel.com>
Date: Mon, 16 Dec 2024 03:49:52 -0800
Subject: [PATCH] [NFC][[webkit.UncountedLambdaCapturesChecker] Remove
unnecessary check
CXXMD is checked for null, but it can't be null inside of a visitor's
method. Found by a static analyzer tool.
---
.../Checkers/WebKit/UncountedLambdaCapturesChecker.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/clang/lib/StaticAnalyzer/Checkers/WebKit/UncountedLambdaCapturesChecker.cpp b/clang/lib/StaticAnalyzer/Checkers/WebKit/UncountedLambdaCapturesChecker.cpp
index ac5cf3d899d55a..d786b02e2d7f3a 100644
--- a/clang/lib/StaticAnalyzer/Checkers/WebKit/UncountedLambdaCapturesChecker.cpp
+++ b/clang/lib/StaticAnalyzer/Checkers/WebKit/UncountedLambdaCapturesChecker.cpp
@@ -52,7 +52,7 @@ class UncountedLambdaCapturesChecker
bool TraverseCXXMethodDecl(CXXMethodDecl *CXXMD) override {
llvm::SaveAndRestore SavedDecl(ClsType);
- if (CXXMD && CXXMD->isInstance())
+ if (CXXMD->isInstance())
ClsType = CXXMD->getThisType();
return DynamicRecursiveASTVisitor::TraverseCXXMethodDecl(CXXMD);
}
More information about the cfe-commits
mailing list