[clang] [clang][bytecode] Fix some shift edge cases (PR #119895)

Fri Dec 13 22:43:13 PST 2024

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `sanitizer-aarch64-linux-bootstrap-msan` running on `sanitizer-buildbot10` while building `clang` at step 2 "annotate".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/94/builds/2858

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 2 (annotate) failure: 'python ../sanitizer_buildbot/sanitizers/zorg/buildbot/builders/sanitizers/buildbot_selector.py' (failure)
...
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-msan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:506: note: using lld-link: /home/b/sanitizer-aarch64-linux-bootstrap-msan/build/llvm_build_msan/bin/lld-link
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-msan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:506: note: using ld64.lld: /home/b/sanitizer-aarch64-linux-bootstrap-msan/build/llvm_build_msan/bin/ld64.lld
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-msan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:506: note: using wasm-ld: /home/b/sanitizer-aarch64-linux-bootstrap-msan/build/llvm_build_msan/bin/wasm-ld
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-msan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:506: note: using ld.lld: /home/b/sanitizer-aarch64-linux-bootstrap-msan/build/llvm_build_msan/bin/ld.lld
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-msan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:506: note: using lld-link: /home/b/sanitizer-aarch64-linux-bootstrap-msan/build/llvm_build_msan/bin/lld-link
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-msan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:506: note: using ld64.lld: /home/b/sanitizer-aarch64-linux-bootstrap-msan/build/llvm_build_msan/bin/ld64.lld
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-msan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:506: note: using wasm-ld: /home/b/sanitizer-aarch64-linux-bootstrap-msan/build/llvm_build_msan/bin/wasm-ld
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-msan/build/llvm-project/llvm/utils/lit/lit/main.py:72: note: The test suite configuration requested an individual test timeout of 0 seconds but a timeout of 900 seconds was requested on the command line. Forcing timeout to be 900 seconds.
-- Testing: 85474 tests, 72 workers --
Testing: 
FAIL: Clang :: AST/ByteCode/shifts.cpp (126 of 85474)
******************** TEST 'Clang :: AST/ByteCode/shifts.cpp' FAILED ********************
Exit Code: 1

Command Output (stderr):
--
RUN: at line 1: /home/b/sanitizer-aarch64-linux-bootstrap-msan/build/llvm_build_msan/bin/clang -cc1 -internal-isystem /home/b/sanitizer-aarch64-linux-bootstrap-msan/build/llvm_build_msan/lib/clang/20/include -nostdsysteminc -fexperimental-new-constant-interpreter -std=c++20 -verify=expected,all /home/b/sanitizer-aarch64-linux-bootstrap-msan/build/llvm-project/clang/test/AST/ByteCode/shifts.cpp
+ /home/b/sanitizer-aarch64-linux-bootstrap-msan/build/llvm_build_msan/bin/clang -cc1 -internal-isystem /home/b/sanitizer-aarch64-linux-bootstrap-msan/build/llvm_build_msan/lib/clang/20/include -nostdsysteminc -fexperimental-new-constant-interpreter -std=c++20 -verify=expected,all /home/b/sanitizer-aarch64-linux-bootstrap-msan/build/llvm-project/clang/test/AST/ByteCode/shifts.cpp
error: 'all-error' diagnostics seen but not expected: 
  File /home/b/sanitizer-aarch64-linux-bootstrap-msan/build/llvm-project/clang/test/AST/ByteCode/shifts.cpp Line 205: static assertion failed due to requirement '((wchar_t)-1U >> 31) == -1'
error: 'all-note' diagnostics seen but not expected: 
  File /home/b/sanitizer-aarch64-linux-bootstrap-msan/build/llvm-project/clang/test/AST/ByteCode/shifts.cpp Line 205: expression evaluates to '1 == -1'
2 errors generated.

--

********************
Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90.. 
Slowest Tests:
--------------------------------------------------------------------------
103.03s: Clang :: Driver/fsanitize.c
89.72s: LLVM :: CodeGen/AMDGPU/memintrinsic-unroll.ll
84.62s: Clang :: Preprocessor/riscv-target-features.c
78.89s: Clang :: Driver/arm-cortex-cpus-2.c
77.84s: Clang :: Driver/arm-cortex-cpus-1.c
69.61s: Clang :: Analysis/runtime-regression.c
69.61s: LLVM :: CodeGen/AMDGPU/sched-group-barrier-pipeline-solver.mir
68.93s: Clang :: OpenMP/target_defaultmap_codegen_01.cpp
66.64s: Clang :: OpenMP/target_update_codegen.cpp
60.10s: LLVM :: CodeGen/RISCV/attributes.ll
58.77s: Clang :: Driver/clang_f_opts.c
57.36s: Clang :: CodeGen/AArch64/sve-intrinsics/acle_sve_reinterpret.c
54.66s: Clang :: Preprocessor/aarch64-target-features.c
53.77s: Clang :: Preprocessor/arm-target-features.c
52.15s: Clang :: Driver/linux-ld.c
50.25s: Clang :: CodeGen/AArch64/sve-intrinsics/acle_sve_reinterpret-bfloat.c
49.91s: Clang :: Analysis/a_flaky_crash.cpp
49.76s: LLVM :: CodeGen/ARM/build-attributes.ll
47.36s: Clang :: Driver/cl-options.c
Step 11 (stage2/msan check) failure: stage2/msan check (failure)
...
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-msan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:506: note: using lld-link: /home/b/sanitizer-aarch64-linux-bootstrap-msan/build/llvm_build_msan/bin/lld-link
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-msan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:506: note: using ld64.lld: /home/b/sanitizer-aarch64-linux-bootstrap-msan/build/llvm_build_msan/bin/ld64.lld
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-msan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:506: note: using wasm-ld: /home/b/sanitizer-aarch64-linux-bootstrap-msan/build/llvm_build_msan/bin/wasm-ld
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-msan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:506: note: using ld.lld: /home/b/sanitizer-aarch64-linux-bootstrap-msan/build/llvm_build_msan/bin/ld.lld
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-msan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:506: note: using lld-link: /home/b/sanitizer-aarch64-linux-bootstrap-msan/build/llvm_build_msan/bin/lld-link
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-msan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:506: note: using ld64.lld: /home/b/sanitizer-aarch64-linux-bootstrap-msan/build/llvm_build_msan/bin/ld64.lld
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-msan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:506: note: using wasm-ld: /home/b/sanitizer-aarch64-linux-bootstrap-msan/build/llvm_build_msan/bin/wasm-ld
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-msan/build/llvm-project/llvm/utils/lit/lit/main.py:72: note: The test suite configuration requested an individual test timeout of 0 seconds but a timeout of 900 seconds was requested on the command line. Forcing timeout to be 900 seconds.
-- Testing: 85474 tests, 72 workers --
Testing: 
FAIL: Clang :: AST/ByteCode/shifts.cpp (126 of 85474)
******************** TEST 'Clang :: AST/ByteCode/shifts.cpp' FAILED ********************
Exit Code: 1

Command Output (stderr):
--
RUN: at line 1: /home/b/sanitizer-aarch64-linux-bootstrap-msan/build/llvm_build_msan/bin/clang -cc1 -internal-isystem /home/b/sanitizer-aarch64-linux-bootstrap-msan/build/llvm_build_msan/lib/clang/20/include -nostdsysteminc -fexperimental-new-constant-interpreter -std=c++20 -verify=expected,all /home/b/sanitizer-aarch64-linux-bootstrap-msan/build/llvm-project/clang/test/AST/ByteCode/shifts.cpp
+ /home/b/sanitizer-aarch64-linux-bootstrap-msan/build/llvm_build_msan/bin/clang -cc1 -internal-isystem /home/b/sanitizer-aarch64-linux-bootstrap-msan/build/llvm_build_msan/lib/clang/20/include -nostdsysteminc -fexperimental-new-constant-interpreter -std=c++20 -verify=expected,all /home/b/sanitizer-aarch64-linux-bootstrap-msan/build/llvm-project/clang/test/AST/ByteCode/shifts.cpp
error: 'all-error' diagnostics seen but not expected: 
  File /home/b/sanitizer-aarch64-linux-bootstrap-msan/build/llvm-project/clang/test/AST/ByteCode/shifts.cpp Line 205: static assertion failed due to requirement '((wchar_t)-1U >> 31) == -1'
error: 'all-note' diagnostics seen but not expected: 
  File /home/b/sanitizer-aarch64-linux-bootstrap-msan/build/llvm-project/clang/test/AST/ByteCode/shifts.cpp Line 205: expression evaluates to '1 == -1'
2 errors generated.

--

********************
Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90.. 
Slowest Tests:
--------------------------------------------------------------------------
103.03s: Clang :: Driver/fsanitize.c
89.72s: LLVM :: CodeGen/AMDGPU/memintrinsic-unroll.ll
84.62s: Clang :: Preprocessor/riscv-target-features.c
78.89s: Clang :: Driver/arm-cortex-cpus-2.c
77.84s: Clang :: Driver/arm-cortex-cpus-1.c
69.61s: Clang :: Analysis/runtime-regression.c
69.61s: LLVM :: CodeGen/AMDGPU/sched-group-barrier-pipeline-solver.mir
68.93s: Clang :: OpenMP/target_defaultmap_codegen_01.cpp
66.64s: Clang :: OpenMP/target_update_codegen.cpp
60.10s: LLVM :: CodeGen/RISCV/attributes.ll
58.77s: Clang :: Driver/clang_f_opts.c
57.36s: Clang :: CodeGen/AArch64/sve-intrinsics/acle_sve_reinterpret.c
54.66s: Clang :: Preprocessor/aarch64-target-features.c
53.77s: Clang :: Preprocessor/arm-target-features.c
52.15s: Clang :: Driver/linux-ld.c
50.25s: Clang :: CodeGen/AArch64/sve-intrinsics/acle_sve_reinterpret-bfloat.c
49.91s: Clang :: Analysis/a_flaky_crash.cpp
49.76s: LLVM :: CodeGen/ARM/build-attributes.ll
47.36s: Clang :: Driver/cl-options.c
Step 13 (stage3/msan check) failure: stage3/msan check (failure)
...
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-msan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:506: note: using lld-link: /home/b/sanitizer-aarch64-linux-bootstrap-msan/build/llvm_build2_msan/bin/lld-link
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-msan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:506: note: using ld64.lld: /home/b/sanitizer-aarch64-linux-bootstrap-msan/build/llvm_build2_msan/bin/ld64.lld
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-msan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:506: note: using wasm-ld: /home/b/sanitizer-aarch64-linux-bootstrap-msan/build/llvm_build2_msan/bin/wasm-ld
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-msan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:506: note: using ld.lld: /home/b/sanitizer-aarch64-linux-bootstrap-msan/build/llvm_build2_msan/bin/ld.lld
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-msan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:506: note: using lld-link: /home/b/sanitizer-aarch64-linux-bootstrap-msan/build/llvm_build2_msan/bin/lld-link
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-msan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:506: note: using ld64.lld: /home/b/sanitizer-aarch64-linux-bootstrap-msan/build/llvm_build2_msan/bin/ld64.lld
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-msan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:506: note: using wasm-ld: /home/b/sanitizer-aarch64-linux-bootstrap-msan/build/llvm_build2_msan/bin/wasm-ld
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-msan/build/llvm-project/llvm/utils/lit/lit/main.py:72: note: The test suite configuration requested an individual test timeout of 0 seconds but a timeout of 900 seconds was requested on the command line. Forcing timeout to be 900 seconds.
-- Testing: 82642 tests, 72 workers --
Testing: 
FAIL: Clang :: AST/ByteCode/shifts.cpp (134 of 82642)
******************** TEST 'Clang :: AST/ByteCode/shifts.cpp' FAILED ********************
Exit Code: 1

Command Output (stderr):
--
RUN: at line 1: /home/b/sanitizer-aarch64-linux-bootstrap-msan/build/llvm_build2_msan/bin/clang -cc1 -internal-isystem /home/b/sanitizer-aarch64-linux-bootstrap-msan/build/llvm_build2_msan/lib/clang/20/include -nostdsysteminc -fexperimental-new-constant-interpreter -std=c++20 -verify=expected,all /home/b/sanitizer-aarch64-linux-bootstrap-msan/build/llvm-project/clang/test/AST/ByteCode/shifts.cpp
+ /home/b/sanitizer-aarch64-linux-bootstrap-msan/build/llvm_build2_msan/bin/clang -cc1 -internal-isystem /home/b/sanitizer-aarch64-linux-bootstrap-msan/build/llvm_build2_msan/lib/clang/20/include -nostdsysteminc -fexperimental-new-constant-interpreter -std=c++20 -verify=expected,all /home/b/sanitizer-aarch64-linux-bootstrap-msan/build/llvm-project/clang/test/AST/ByteCode/shifts.cpp
error: 'all-error' diagnostics seen but not expected: 
  File /home/b/sanitizer-aarch64-linux-bootstrap-msan/build/llvm-project/clang/test/AST/ByteCode/shifts.cpp Line 205: static assertion failed due to requirement '((wchar_t)-1U >> 31) == -1'
error: 'all-note' diagnostics seen but not expected: 
  File /home/b/sanitizer-aarch64-linux-bootstrap-msan/build/llvm-project/clang/test/AST/ByteCode/shifts.cpp Line 205: expression evaluates to '1 == -1'
2 errors generated.

--

********************
Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90.. 
Slowest Tests:
--------------------------------------------------------------------------
23.91s: LLVM :: tools/llvm-reduce/parallel-workitem-kill.ll
22.43s: Clang :: Driver/fsanitize.c
19.46s: Clang :: Preprocessor/riscv-target-features.c
17.20s: Clang :: OpenMP/target_defaultmap_codegen_01.cpp
16.89s: Clang :: OpenMP/target_update_codegen.cpp
15.94s: Clang :: Driver/arm-cortex-cpus-2.c
15.79s: Clang :: Driver/arm-cortex-cpus-1.c
14.04s: Clang :: CodeGen/AArch64/sve-intrinsics/acle_sve_reinterpret.c
13.34s: Clang :: Preprocessor/aarch64-target-features.c
13.31s: Clang :: Preprocessor/arm-target-features.c
13.30s: Clang :: Analysis/runtime-regression.c
12.82s: LLVM :: CodeGen/AMDGPU/memintrinsic-unroll.ll
12.21s: lit :: shtest-define.py
11.82s: Clang :: Preprocessor/predefined-arch-macros.c
11.80s: Clang :: Analysis/a_flaky_crash.cpp
11.38s: LLVM :: CodeGen/RISCV/attributes.ll
10.87s: Clang :: CodeGen/AArch64/sve-intrinsics/acle_sve_reinterpret-bfloat.c
10.67s: Clang :: Driver/linux-ld.c
10.45s: Clang :: Driver/clang_f_opts.c

```

</details>

https://github.com/llvm/llvm-project/pull/119895