[clang] [clang][bytecode] Fix some shift edge cases (PR #119895)

Fri Dec 13 22:02:09 PST 2024

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `sanitizer-aarch64-linux-bootstrap-hwasan` running on `sanitizer-buildbot12` while building `clang` at step 2 "annotate".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/55/builds/4295

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 2 (annotate) failure: 'python ../sanitizer_buildbot/sanitizers/zorg/buildbot/builders/sanitizers/buildbot_selector.py' (failure)
...
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:506: note: using lld-link: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/bin/lld-link
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:506: note: using ld64.lld: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/bin/ld64.lld
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:506: note: using wasm-ld: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/bin/wasm-ld
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:506: note: using ld.lld: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/bin/ld.lld
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:506: note: using lld-link: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/bin/lld-link
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:506: note: using ld64.lld: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/bin/ld64.lld
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:506: note: using wasm-ld: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/bin/wasm-ld
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/llvm/utils/lit/lit/main.py:72: note: The test suite configuration requested an individual test timeout of 0 seconds but a timeout of 900 seconds was requested on the command line. Forcing timeout to be 900 seconds.
-- Testing: 85475 tests, 72 workers --
Testing: 
FAIL: Clang :: AST/ByteCode/shifts.cpp (123 of 85475)
******************** TEST 'Clang :: AST/ByteCode/shifts.cpp' FAILED ********************
Exit Code: 1

Command Output (stderr):
--
RUN: at line 1: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/bin/clang -cc1 -internal-isystem /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/lib/clang/20/include -nostdsysteminc -fexperimental-new-constant-interpreter -std=c++20 -verify=expected,all /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/clang/test/AST/ByteCode/shifts.cpp
+ /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/bin/clang -cc1 -internal-isystem /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/lib/clang/20/include -nostdsysteminc -fexperimental-new-constant-interpreter -std=c++20 -verify=expected,all /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/clang/test/AST/ByteCode/shifts.cpp
error: 'all-error' diagnostics seen but not expected: 
  File /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/clang/test/AST/ByteCode/shifts.cpp Line 205: static assertion failed due to requirement '((wchar_t)-1U >> 31) == -1'
error: 'all-note' diagnostics seen but not expected: 
  File /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/clang/test/AST/ByteCode/shifts.cpp Line 205: expression evaluates to '1 == -1'
2 errors generated.

--

********************
Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90.. 
Slowest Tests:
--------------------------------------------------------------------------
48.94s: Clang :: Driver/fsanitize.c
40.39s: Clang :: Preprocessor/riscv-target-features.c
37.52s: Clang :: Driver/arm-cortex-cpus-2.c
36.70s: Clang :: Driver/arm-cortex-cpus-1.c
35.54s: LLVM :: CodeGen/AMDGPU/sched-group-barrier-pipeline-solver.mir
33.46s: Clang :: OpenMP/target_defaultmap_codegen_01.cpp
33.33s: Clang :: OpenMP/target_update_codegen.cpp
28.80s: Clang :: Preprocessor/aarch64-target-features.c
28.75s: Clang :: Preprocessor/arm-target-features.c
26.48s: Clang :: Driver/clang_f_opts.c
25.60s: LLVM :: CodeGen/RISCV/attributes.ll
25.16s: Clang :: Preprocessor/predefined-arch-macros.c
24.58s: Clang :: Driver/linux-ld.c
23.75s: LLVM :: tools/llvm-reduce/parallel-workitem-kill.ll
23.56s: LLVM :: CodeGen/ARM/build-attributes.ll
22.44s: Clang :: Driver/cl-options.c
21.11s: Clang :: Driver/x86-target-features.c
20.41s: LLVM :: CodeGen/AMDGPU/memintrinsic-unroll.ll
18.56s: Clang :: CodeGen/AArch64/sve-intrinsics/acle_sve_reinterpret.c
Step 11 (stage2/hwasan check) failure: stage2/hwasan check (failure)
...
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:506: note: using lld-link: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/bin/lld-link
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:506: note: using ld64.lld: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/bin/ld64.lld
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:506: note: using wasm-ld: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/bin/wasm-ld
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:506: note: using ld.lld: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/bin/ld.lld
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:506: note: using lld-link: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/bin/lld-link
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:506: note: using ld64.lld: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/bin/ld64.lld
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:506: note: using wasm-ld: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/bin/wasm-ld
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/llvm/utils/lit/lit/main.py:72: note: The test suite configuration requested an individual test timeout of 0 seconds but a timeout of 900 seconds was requested on the command line. Forcing timeout to be 900 seconds.
-- Testing: 85475 tests, 72 workers --
Testing: 
FAIL: Clang :: AST/ByteCode/shifts.cpp (123 of 85475)
******************** TEST 'Clang :: AST/ByteCode/shifts.cpp' FAILED ********************
Exit Code: 1

Command Output (stderr):
--
RUN: at line 1: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/bin/clang -cc1 -internal-isystem /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/lib/clang/20/include -nostdsysteminc -fexperimental-new-constant-interpreter -std=c++20 -verify=expected,all /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/clang/test/AST/ByteCode/shifts.cpp
+ /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/bin/clang -cc1 -internal-isystem /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/lib/clang/20/include -nostdsysteminc -fexperimental-new-constant-interpreter -std=c++20 -verify=expected,all /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/clang/test/AST/ByteCode/shifts.cpp
error: 'all-error' diagnostics seen but not expected: 
  File /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/clang/test/AST/ByteCode/shifts.cpp Line 205: static assertion failed due to requirement '((wchar_t)-1U >> 31) == -1'
error: 'all-note' diagnostics seen but not expected: 
  File /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/clang/test/AST/ByteCode/shifts.cpp Line 205: expression evaluates to '1 == -1'
2 errors generated.

--

********************
Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90.. 
Slowest Tests:
--------------------------------------------------------------------------
48.94s: Clang :: Driver/fsanitize.c
40.39s: Clang :: Preprocessor/riscv-target-features.c
37.52s: Clang :: Driver/arm-cortex-cpus-2.c
36.70s: Clang :: Driver/arm-cortex-cpus-1.c
35.54s: LLVM :: CodeGen/AMDGPU/sched-group-barrier-pipeline-solver.mir
33.46s: Clang :: OpenMP/target_defaultmap_codegen_01.cpp
33.33s: Clang :: OpenMP/target_update_codegen.cpp
28.80s: Clang :: Preprocessor/aarch64-target-features.c
28.75s: Clang :: Preprocessor/arm-target-features.c
26.48s: Clang :: Driver/clang_f_opts.c
25.60s: LLVM :: CodeGen/RISCV/attributes.ll
25.16s: Clang :: Preprocessor/predefined-arch-macros.c
24.58s: Clang :: Driver/linux-ld.c
23.75s: LLVM :: tools/llvm-reduce/parallel-workitem-kill.ll
23.56s: LLVM :: CodeGen/ARM/build-attributes.ll
22.44s: Clang :: Driver/cl-options.c
21.11s: Clang :: Driver/x86-target-features.c
20.41s: LLVM :: CodeGen/AMDGPU/memintrinsic-unroll.ll
18.56s: Clang :: CodeGen/AArch64/sve-intrinsics/acle_sve_reinterpret.c
Step 13 (stage3/hwasan check) failure: stage3/hwasan check (failure)
...
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:506: note: using lld-link: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build2_hwasan/bin/lld-link
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:506: note: using ld64.lld: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build2_hwasan/bin/ld64.lld
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:506: note: using wasm-ld: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build2_hwasan/bin/wasm-ld
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:506: note: using ld.lld: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build2_hwasan/bin/ld.lld
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:506: note: using lld-link: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build2_hwasan/bin/lld-link
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:506: note: using ld64.lld: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build2_hwasan/bin/ld64.lld
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:506: note: using wasm-ld: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build2_hwasan/bin/wasm-ld
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/llvm/utils/lit/lit/main.py:72: note: The test suite configuration requested an individual test timeout of 0 seconds but a timeout of 900 seconds was requested on the command line. Forcing timeout to be 900 seconds.
-- Testing: 82642 tests, 72 workers --
Testing: 
FAIL: Clang :: AST/ByteCode/shifts.cpp (132 of 82642)
******************** TEST 'Clang :: AST/ByteCode/shifts.cpp' FAILED ********************
Exit Code: 1

Command Output (stderr):
--
RUN: at line 1: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build2_hwasan/bin/clang -cc1 -internal-isystem /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build2_hwasan/lib/clang/20/include -nostdsysteminc -fexperimental-new-constant-interpreter -std=c++20 -verify=expected,all /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/clang/test/AST/ByteCode/shifts.cpp
+ /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build2_hwasan/bin/clang -cc1 -internal-isystem /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build2_hwasan/lib/clang/20/include -nostdsysteminc -fexperimental-new-constant-interpreter -std=c++20 -verify=expected,all /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/clang/test/AST/ByteCode/shifts.cpp
error: 'all-error' diagnostics seen but not expected: 
  File /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/clang/test/AST/ByteCode/shifts.cpp Line 205: static assertion failed due to requirement '((wchar_t)-1U >> 31) == -1'
error: 'all-note' diagnostics seen but not expected: 
  File /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/clang/test/AST/ByteCode/shifts.cpp Line 205: expression evaluates to '1 == -1'
2 errors generated.

--

********************
Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90.. 
Slowest Tests:
--------------------------------------------------------------------------
23.45s: LLVM :: tools/llvm-reduce/parallel-workitem-kill.ll
18.08s: Clang :: Driver/fsanitize.c
14.39s: Clang :: Preprocessor/riscv-target-features.c
13.68s: Clang :: Driver/arm-cortex-cpus-2.c
13.26s: Clang :: Driver/arm-cortex-cpus-1.c
12.78s: Clang :: OpenMP/target_defaultmap_codegen_01.cpp
12.58s: Clang :: OpenMP/target_update_codegen.cpp
10.16s: Clang :: Preprocessor/aarch64-target-features.c
10.01s: LLVM-Unit :: Support/./SupportTests/ProgramEnvTest/TestExecuteNoWaitDetached
9.82s: Clang :: Preprocessor/arm-target-features.c
9.42s: Clang :: Driver/clang_f_opts.c
9.09s: Clang :: Driver/linux-ld.c
8.53s: Clang :: Preprocessor/predefined-arch-macros.c
7.96s: Clang :: Driver/cl-options.c
7.84s: Clang :: Driver/x86-target-features.c
7.75s: LLVM :: CodeGen/ARM/build-attributes.ll
7.52s: LLVM :: CodeGen/AMDGPU/memintrinsic-unroll.ll
7.31s: Clang :: Analysis/a_flaky_crash.cpp
7.26s: LLVM :: CodeGen/RISCV/attributes.ll

```

</details>

https://github.com/llvm/llvm-project/pull/119895