[clang] [clang][Driver][Darwin] Optionally use xcselect to find macOS SDK (PR #119670)

Carlo Cabrera via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 13 09:06:22 PST 2024


carlocab wrote:

> > I don't quite understand why the failing tests are caused to fail when `CLANG_USE_XCSELECT` is enabled. I'll have to put more time into investigating them -- I consider this another blocker for enabling this feature more widely.
> 
> I think the issue is that the implicit `-isysroot` flag from `libxcselect` changes the deployment target, which then also changes the behaviour of `clang` in these tests. But I'll need to verify this locally to make sure.

Yea, this seems right. Adding appropriate `-mmacosx-version-min=` flags to the failing tests seems to make them succeed again. Not sure if that's the right move, though.

https://github.com/llvm/llvm-project/pull/119670


More information about the cfe-commits mailing list