MaskRay wrote: In general, functional changes need tests. When the initial https://reviews.llvm.org/D145227 landed, I did not have a chance to look, and the tests may have gap. When adding new functionality, ensure that the test coverage gets improved. https://github.com/llvm/llvm-project/pull/118192