[clang] [WebKit checkers] Recognize ensureFoo functions (PR #119681)

via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 12 01:41:03 PST 2024


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff dd8d85dba6e8f74a55fb5053107797e21894a0c6 0982f5ca3f9d1ea713b1e34b6e6b9d08ff65e6f1 --extensions h,cpp -- clang/lib/StaticAnalyzer/Checkers/WebKit/ASTUtils.cpp clang/lib/StaticAnalyzer/Checkers/WebKit/ASTUtils.h clang/lib/StaticAnalyzer/Checkers/WebKit/RawPtrRefCallArgsChecker.cpp clang/lib/StaticAnalyzer/Checkers/WebKit/RawPtrRefLocalVarsChecker.cpp clang/test/Analysis/Checkers/WebKit/call-args-checked-const-member.cpp clang/test/Analysis/Checkers/WebKit/call-args-counted-const-member.cpp clang/test/Analysis/Checkers/WebKit/local-vars-checked-const-member.cpp clang/test/Analysis/Checkers/WebKit/local-vars-counted-const-member.cpp clang/test/Analysis/Checkers/WebKit/mock-types.h
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/clang/lib/StaticAnalyzer/Checkers/WebKit/ASTUtils.cpp b/clang/lib/StaticAnalyzer/Checkers/WebKit/ASTUtils.cpp
index 4086b267b6..da6d4598cb 100644
--- a/clang/lib/StaticAnalyzer/Checkers/WebKit/ASTUtils.cpp
+++ b/clang/lib/StaticAnalyzer/Checkers/WebKit/ASTUtils.cpp
@@ -202,7 +202,7 @@ bool EnsureFunctionAnalysis::isACallToEnsureFn(const clang::Expr *E) const {
   auto *Callee = MCE->getDirectCallee();
   if (!Callee)
     return false;
-  auto* Body = Callee->getBody();
+  auto *Body = Callee->getBody();
   if (!Body)
     return false;
   auto [CacheIt, IsNew] = Cache.insert(std::make_pair(Callee, false));
diff --git a/clang/lib/StaticAnalyzer/Checkers/WebKit/ASTUtils.h b/clang/lib/StaticAnalyzer/Checkers/WebKit/ASTUtils.h
index a4d46235dc..b508043d0f 100644
--- a/clang/lib/StaticAnalyzer/Checkers/WebKit/ASTUtils.h
+++ b/clang/lib/StaticAnalyzer/Checkers/WebKit/ASTUtils.h
@@ -67,8 +67,8 @@ bool isASafeCallArg(const clang::Expr *E);
 /// \returns true if E is a MemberExpr accessing a const smart pointer type.
 bool isConstOwnerPtrMemberExpr(const clang::Expr *E);
 
-/// \returns true if E is a CXXMemberCallExpr which returns a const smart pointer
-/// type.
+/// \returns true if E is a CXXMemberCallExpr which returns a const smart
+/// pointer type.
 class EnsureFunctionAnalysis {
   using CacheTy = llvm::DenseMap<const FunctionDecl *, bool>;
   mutable CacheTy Cache{};

``````````

</details>


https://github.com/llvm/llvm-project/pull/119681


More information about the cfe-commits mailing list