[clang] [AArch64] Refactor implementation of FP8 types (NFC) (PR #118969)

via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 11 10:57:47 PST 2024


================
@@ -4374,15 +4379,18 @@ ASTContext::getBuiltinVectorTypeInfo(const BuiltinType *Ty) const {
                                ElBits, NF)                                     \
   case BuiltinType::Id:                                                        \
     return {BFloat16Ty, llvm::ElementCount::getScalable(NumEls), NF};
+#define SVE_VECTOR_TYPE_MFLOAT(Name, MangledName, Id, SingletonId, NumEls,     \
+                               ElBits, NF)                                     \
+  case BuiltinType::Id:                                                        \
+    return {MFloat8Ty, llvm::ElementCount::getScalable(NumEls), NF};
----------------
CarolineConcatto wrote:

Why are you returning MFloat8Ty it should be SingletonId, no?
At least it should have an explanation to why this is different.
Is it because of AArrch64.cpp to build the scalable vector.

https://github.com/llvm/llvm-project/pull/118969


More information about the cfe-commits mailing list