[clang] 3376bad - Eliminate duplicate call in Clang driver (NFC)

Aaron Puchert via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 10 11:01:48 PST 2024


Author: Aaron Puchert
Date: 2024-12-10T20:01:19+01:00
New Revision: 3376bad13216da8950bcdeb564df26d5ce4c12bc

URL: https://github.com/llvm/llvm-project/commit/3376bad13216da8950bcdeb564df26d5ce4c12bc
DIFF: https://github.com/llvm/llvm-project/commit/3376bad13216da8950bcdeb564df26d5ce4c12bc.diff

LOG: Eliminate duplicate call in Clang driver (NFC)

The only difference is the usage of `JobAction* JA` versus `Action* A`
in one argument, but `JA = cast<JobAction>(A)`, and the called function
is inherited from `Action`.

Added: 
    

Modified: 
    clang/lib/Driver/Driver.cpp

Removed: 
    


################################################################################
diff  --git a/clang/lib/Driver/Driver.cpp b/clang/lib/Driver/Driver.cpp
index 6ba13d73411690..fb73b62cf2daed 100644
--- a/clang/lib/Driver/Driver.cpp
+++ b/clang/lib/Driver/Driver.cpp
@@ -5815,15 +5815,10 @@ InputInfoList Driver::BuildJobsForActionNoCache(
     }
   } else {
     if (UnbundlingResults.empty())
-      T->ConstructJob(
-          C, *JA, Result, InputInfos,
-          C.getArgsForToolChain(TC, BoundArch, JA->getOffloadingDeviceKind()),
-          LinkingOutput);
+      T->ConstructJob(C, *JA, Result, InputInfos, Args, LinkingOutput);
     else
-      T->ConstructJobMultipleOutputs(
-          C, *JA, UnbundlingResults, InputInfos,
-          C.getArgsForToolChain(TC, BoundArch, JA->getOffloadingDeviceKind()),
-          LinkingOutput);
+      T->ConstructJobMultipleOutputs(C, *JA, UnbundlingResults, InputInfos,
+                                     Args, LinkingOutput);
   }
   return {Result};
 }


        


More information about the cfe-commits mailing list