[clang] [llvm] [AArch64] Refactor implementation of FP8 types (NFC) (PR #118969)

via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 6 10:08:45 PST 2024


================
@@ -650,6 +655,8 @@ llvm::Type *CodeGenTypes::ConvertType(QualType T) {
     // An ext_vector_type of Bool is really a vector of bits.
     llvm::Type *IRElemTy = VT->isExtVectorBoolType()
                                ? llvm::Type::getInt1Ty(getLLVMContext())
+                           : VT->getElementType()->isMFloat8Type()
----------------
SpencerAbson wrote:

Might it be worth adding  a comment to explain why we are avoiding `ConvertType(VT->getElementType())`? Similarly with change for the builtin type above.

https://github.com/llvm/llvm-project/pull/118969


More information about the cfe-commits mailing list