[clang] [Clang][perf-training] Fix clean command in perf-helper.py (PR #118978)

Tom Stellard via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 6 06:12:33 PST 2024


https://github.com/tstellar created https://github.com/llvm/llvm-project/pull/118978

The first path argument was always being ignored, and since most calls to this command only passed one path, it wasn't actually doing anything in most cases.

This bug was introduced by dd0356d741aefa25ece973d6cc4b55dcb73b84b4.

>From 117a920a33527e8bcd030823e5fc086603588f8e Mon Sep 17 00:00:00 2001
From: Tom Stellard <tstellar at redhat.com>
Date: Thu, 5 Dec 2024 14:56:23 +0000
Subject: [PATCH] [Clang][perf-training] Fix clean command in perf-helper.py

The first path argument was always being ignored, and since most
calls to this command only passed one path, it wasn't actually doing
anything in most cases.
---
 clang/utils/perf-training/perf-helper.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/clang/utils/perf-training/perf-helper.py b/clang/utils/perf-training/perf-helper.py
index 3ed42a187fd803..d76c6ede3fe5a2 100644
--- a/clang/utils/perf-training/perf-helper.py
+++ b/clang/utils/perf-training/perf-helper.py
@@ -36,7 +36,7 @@ def clean(args):
             + "\tRemoves all files with extension from <path>."
         )
         return 1
-    for path in args[1:-1]:
+    for path in args[0:-1]:
         for filename in findFilesWithExtension(path, args[-1]):
             os.remove(filename)
     return 0



More information about the cfe-commits mailing list