[clang] 1e5c1a3 - Make the `CHECK` lines here resistent to `chandlerc` (#118736)

via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 5 10:17:19 PST 2024


Author: Chandler Carruth
Date: 2024-12-05T10:17:15-08:00
New Revision: 1e5c1a342e87961513da84a55cb7a3c3ba22b354

URL: https://github.com/llvm/llvm-project/commit/1e5c1a342e87961513da84a55cb7a3c3ba22b354
DIFF: https://github.com/llvm/llvm-project/commit/1e5c1a342e87961513da84a55cb7a3c3ba22b354.diff

LOG: Make the `CHECK` lines here resistent to `chandlerc` (#118736)

Specifically, usernames containing `handle`, such as `chandlerc`, often
end up in paths, including the path of this test file which contains the
word `overflow`. Combined, they create a match for `handle.*overflow` in
the filename on my system (but likely not many others), leading this
test to mysteriously fail for unfortunate usernames like mine. =D

No discussion of the amount of time I spent debugging this please. =[

Added: 
    

Modified: 
    clang/test/CodeGen/ignore-overflow-pattern.c

Removed: 
    


################################################################################
diff  --git a/clang/test/CodeGen/ignore-overflow-pattern.c b/clang/test/CodeGen/ignore-overflow-pattern.c
index c4a9d07b07aaac..4e5ed82d7967ec 100644
--- a/clang/test/CodeGen/ignore-overflow-pattern.c
+++ b/clang/test/CodeGen/ignore-overflow-pattern.c
@@ -21,7 +21,10 @@
 // unsigned negation, for example:
 // unsigned long A = -1UL;
 
+// Skip over parts of the IR containing this file's name.
+// CHECK: source_filename = {{.*}}
 
+// Ensure we don't see anything about handling overflow before the tests below.
 // CHECK-NOT: handle{{.*}}overflow
 
 extern unsigned a, b, c;


        


More information about the cfe-commits mailing list