[clang] Make the `CHECK` lines here resistent to `chandlerc` (PR #118736)

via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 4 19:27:10 PST 2024


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-clang

Author: Chandler Carruth (chandlerc)

<details>
<summary>Changes</summary>

Specifically, usernames containing `handle`, such as `chandlerc`, often end up in paths, including the path of this test file which contains the word `overflow`. Combined, they create a match for `handle.*overflow` in the filename on my system (but likely not many others), leading this test to mysteriously fail for unfortunate usernames like mine. =D

No discussion of the amount of time I spent debugging this please. =[

---
Full diff: https://github.com/llvm/llvm-project/pull/118736.diff


1 Files Affected:

- (modified) clang/test/CodeGen/ignore-overflow-pattern.c (+3) 


``````````diff
diff --git a/clang/test/CodeGen/ignore-overflow-pattern.c b/clang/test/CodeGen/ignore-overflow-pattern.c
index c4a9d07b07aaac..4e5ed82d7967ec 100644
--- a/clang/test/CodeGen/ignore-overflow-pattern.c
+++ b/clang/test/CodeGen/ignore-overflow-pattern.c
@@ -21,7 +21,10 @@
 // unsigned negation, for example:
 // unsigned long A = -1UL;
 
+// Skip over parts of the IR containing this file's name.
+// CHECK: source_filename = {{.*}}
 
+// Ensure we don't see anything about handling overflow before the tests below.
 // CHECK-NOT: handle{{.*}}overflow
 
 extern unsigned a, b, c;

``````````

</details>


https://github.com/llvm/llvm-project/pull/118736


More information about the cfe-commits mailing list