[clang] [HLSL] Add ByteAddressBuffer, RWByteAddressBuffer and RasterizerOrderedByteAddressBuffer definitions to HLSLExternalSemaSource #113477 (PR #116699)

[Helena Kotas via cfe-commits]

================
@@ -540,10 +555,10 @@ struct BuiltinTypeMethodBuilder {
 
     // create method decl
     auto *TSInfo = AST.getTrivialTypeSourceInfo(MethodTy, SourceLocation());
-    Method =
-        CXXMethodDecl::Create(AST, DeclBuilder.Record, SourceLocation(),
-                              NameInfo, MethodTy, TSInfo, SC_None, false, false,
-                              ConstexprSpecKind::Unspecified, SourceLocation());
+    Method = CXXMethodDecl::Create(
+        AST, DeclBuilder.finalizeForwardDeclaration(), SourceLocation(),
----------------
hekota wrote:

This change is not necessary - methods are added when the type is getting completed on its first use, which is long after the forward declaration was created.

https://github.com/llvm/llvm-project/pull/116699