[clang] [clang-cl][flang][dxc] Fix opts exposed to clang-cl/dxc by mistake (PR #118640)

Mészáros Gergely via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 4 06:03:38 PST 2024


================
@@ -1055,11 +1055,11 @@ def z : Separate<["-"], "z">, Flags<[LinkerInput]>,
 def offload_link : Flag<["--"], "offload-link">, Group<Link_Group>,
   HelpText<"Use the new offloading linker to perform the link job.">;
 def Xlinker : Separate<["-"], "Xlinker">, Flags<[LinkerInput, RenderAsInput]>,
-  Visibility<[ClangOption, CLOption, FlangOption, DXCOption]>,
+  Visibility<[ClangOption, FlangOption]>,
----------------
Maetveis wrote:

I believe this and `-Xoffload-linker` could maybe stay if it works for `clang-cl`. For example CMake has been thinking about using such an option if it were available (though this is already possible with `clang-cl` as `-Xclang -Xlinker`): 

> MSVC cl doesn't support driving the linker, or at least didn't when all this was developed.  EDIT: at least not with sufficient control of the linker command line.

(https://gitlab.kitware.com/cmake/cmake/-/issues/24243#note_1289518)

https://github.com/llvm/llvm-project/pull/118640


More information about the cfe-commits mailing list