[clang] [Clang][Darwin] Centralize framework search paths for headers & libraries. (PR #118543)

Steven Wu via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 3 13:51:46 PST 2024


================
@@ -192,6 +192,17 @@ class DarwinSDKInfo {
 Expected<std::optional<DarwinSDKInfo>>
 parseDarwinSDKInfo(llvm::vfs::FileSystem &VFS, StringRef SDKRootPath);
 
+/// Get the system platform prefix for the active target triple.
----------------
cachemeifyoucan wrote:

I feel this header is used for parsing `SDKSettings.json` only. I don't feel like these functions are in the correct place.

If we can do the cleanup for where my other comment is, we can just limit these function to be local to `Driver/Toolchains/Darwin.cpp`. No other file needs to have this information.

https://github.com/llvm/llvm-project/pull/118543


More information about the cfe-commits mailing list