[clang] [clang-repl][CMake][MSVC] Use LINKER: instead of `-Wl` (PR #118518)

via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 3 09:28:37 PST 2024


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-clang

Author: Mészáros Gergely (Maetveis)

<details>
<summary>Changes</summary>

This is supported since CMake 3.12, it should be more portable too. This also avoids passing the option to `clang-cl` when linking, because `clang-cl` accepts any `-W` flags (normally warning flags) during linking (#<!-- -->118516).

---
Full diff: https://github.com/llvm/llvm-project/pull/118518.diff


1 Files Affected:

- (modified) clang/tools/clang-repl/CMakeLists.txt (+1-1) 


``````````diff
diff --git a/clang/tools/clang-repl/CMakeLists.txt b/clang/tools/clang-repl/CMakeLists.txt
index 7aebbe7a19436a..f9a911b0ae8e24 100644
--- a/clang/tools/clang-repl/CMakeLists.txt
+++ b/clang/tools/clang-repl/CMakeLists.txt
@@ -66,7 +66,7 @@ clang_target_link_libraries(clang-repl PRIVATE
 # start to exceed this limit, e.g. when linking for arm-linux-gnueabihf with
 # gold. This flag tells the linker to build a PLT for the full address range.
 # Linkers without this flag are assumed to support proper PLTs by default.
-set(flag_long_plt "-Wl,--long-plt")
+set(flag_long_plt "LINKER:--long-plt")
 check_linker_flag(CXX ${flag_long_plt} HAVE_LINKER_FLAG_LONG_PLT)
 if(HAVE_LINKER_FLAG_LONG_PLT)
   target_link_options(clang-repl PRIVATE ${flag_long_plt})

``````````

</details>


https://github.com/llvm/llvm-project/pull/118518


More information about the cfe-commits mailing list