[clang] [clang][ASTImporter] Not using primary context in lookup table (PR #118466)
Balázs Kéri via cfe-commits
cfe-commits at lists.llvm.org
Tue Dec 3 02:48:43 PST 2024
================
@@ -3165,6 +3165,7 @@ ExpectedDecl ASTNodeImporter::VisitRecordDecl(RecordDecl *D) {
if (Error Err = ImportImplicitMethods(DCXX, FoundCXX))
return std::move(Err);
}
+ return FoundDef;
----------------
balazske wrote:
I put this probably into a new pull request or omit this change. But in the current code I do not see any reason why we can not return here. If there is no return, the later `GetIimportedOrCreateDecl` call should return the existing object. But the imports that are done before the call are not necessary.
https://github.com/llvm/llvm-project/pull/118466
More information about the cfe-commits
mailing list