[clang] [Clang] Add '-Warray-compare' flag for C++ below version 20 (PR #118031)

[Erich Keane via cfe-commits]

================
@@ -10264,6 +10264,10 @@ def warn_depr_array_comparison : Warning<
   "to compare array addresses, use unary '+' to decay operands to pointers">,
   InGroup<DeprecatedArrayCompare>;
 
+def warn_array_comparison : Warning<
+  "comparison between two arrays compare their addresses and will be deprecated in c++20; "
+  "to compare array addresses, use unary '+' to decay operands to pointers">;
----------------
erichkeane wrote:

Did this lose its group?  It still needs one.  Also, I thought someone had suggested doing it inline? Diag message seems acceptable enough to me.

https://github.com/llvm/llvm-project/pull/118031