[clang] [Clang] Add '-Warray-compare' flag for C++ below version 20 (PR #118031)

[Erich Keane via cfe-commits]

================
@@ -10264,6 +10264,11 @@ def warn_depr_array_comparison : Warning<
   "to compare array addresses, use unary '+' to decay operands to pointers">,
   InGroup<DeprecatedArrayCompare>;
 
+def warn_array_comparison : Warning<
+  "comparison between two arrays; "
----------------
erichkeane wrote:

I would love some slight improvement to the first part of this diagnostic.  Just some level of description as to why this is a bad idea.

https://github.com/llvm/llvm-project/pull/118031