[clang-tools-extra] [clangd] Support symbolTags for document symbol (PR #113669)

Dietrich Travkin via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 29 07:37:48 PST 2024


travkin79 wrote:

Hi @chouzz,
I found out that I get symbol tags if the LSP method [textDocument/publishDiagnostics](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_publishDiagnostics) is used. Could you please check your implementation if the symbol tags are only created for diagnostics? If that's the case, could you please add symbol tags also for the following LSP methods and LSP types?

Methods

* [textDocument.documentSymbol](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_documentSymbol)
* [workspace/symbol](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#workspace_symbol)
* [textDocument/prepareCallHierarchy](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_prepareCallHierarchy)
* [callHierarchy/incomingCalls](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#callHierarchy_incomingCalls)
* [callHierarchy/outgoingCalls](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#callHierarchy_outgoingCalls)
* [textDocument/prepareTypeHierarchy](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_prepareTypeHierarchy)
* [typeHierarchy/supertypes](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#typeHierarchy_supertypes)
* [typeHierarchy/subtypes](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#typeHierarchy_subtypes)

Types

* [DocumentSymbol](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#documentSymbol)
* [SymbolInformation](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#symbolInformation)
* [WorkspaceSymbol](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#workspaceSymbol)
* [CallHierarchyItem](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#callHierarchyItem)
* [TypeHierarchyItem](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#typeHierarchyItem)

https://github.com/llvm/llvm-project/pull/113669


More information about the cfe-commits mailing list