[clang] [clang] Format bitfield width diagnostics with thousands-separators (PR #117763)

[via cfe-commits]

Timm =?utf-8?q?Bäder?= <tbaeder at redhat.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/117763 at github.com>


Sirraide wrote:

> Is the lifetime for the APSInt here OK? When I call `Diag()`, will the be diagnostic emitted immediately? Or does the APSInt need to life longer?

Iirc that cause problems if e.g. `PDiag` is used since the diagnostic is stored and emitted later.

https://github.com/llvm/llvm-project/pull/117763