[clang] [analyzer] Modernize, improve and promote chroot checker (PR #117791)

[Balazs Benics via cfe-commits]

================
@@ -98,9 +98,9 @@ void ChrootChecker::evalChroot(const CallEvent &Call, CheckerContext &C) const {
   const auto *CE = cast<CallExpr>(Call.getOriginExpr());
 
   const LocationContext *LCtx = C.getLocationContext();
-  NonLoc RetVal =
-          SVB.conjureSymbolVal(/*SymbolTag=*/nullptr, ChrootCE, LCtx, IntTy, C.blockCount())
-          .castAs<NonLoc>();
+  NonLoc RetVal = SVB.conjureSymbolVal(/*SymbolTag=*/nullptr, ChrootCE, LCtx,
+                                       IntTy, C.blockCount())
+                      .castAs<NonLoc>();
----------------
steakhal wrote:

Now that you directly bind a concrete int as the call result value, I don't think you need this anymore.

https://github.com/llvm/llvm-project/pull/117791