[clang] [clang] Add source range to 'use of undeclared identifier' diagnostics (PR #117671)

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 27 09:50:20 PST 2024


Timm =?utf-8?q?Bäder?= <tbaeder at redhat.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/117671 at github.com>


AaronBallman wrote:

> but this is not a bug introduced by the changes, rather, the newly supplied (valid!) source ranges now get taken into account in `checkRangesForMacroArgExpansion()` in `Frontend/DiagnosticRenderer.cpp`.

Yeah, I think we need to solve that before moving forward with the changes, which is why this keeps not being improved. (It always seems to come back to bite us when we decide that invalid source locations are an in-band indicator of anything.)

https://github.com/llvm/llvm-project/pull/117671


More information about the cfe-commits mailing list