[clang] [analyzer] Avoid out-of-order node traversal on void return (PR #117863)

[Balazs Benics via cfe-commits]

================
@@ -278,7 +278,9 @@ class ExplodedNode : public llvm::FoldingSetNode {
   /// Useful for explaining control flow that follows the current node.
   /// If the statement belongs to a body-farmed definition, retrieve the
   /// call site for that definition.
-  const Stmt *getNextStmtForDiagnostics() const;
+  /// If skipPurge is true, skip the purge-dead-symbols nodes (that are often
+  /// inserted out-of-order by the endinge).
+  const Stmt *getNextStmtForDiagnostics(bool skipPurge) const;
----------------
steakhal wrote:

Our policy was so far to minimize the impact to maximize the change of approval on upstream review.
I think what you say makes sense.

https://github.com/llvm/llvm-project/pull/117863